Handle independent OSC8 hyperlink sequences - #443
Open
Spidy092 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #273.
Colored text inside an OSC8 hyperlink leaves control sequences in the text used to calculate table widths. For example, a hyperlink containing a red
redfollowed bylinkshould occupy eight columns, but the existing parser counts the hyperlink controls when wide-character handling is disabled. It also misses valid direct transitions between hyperlinks and standalone closing sequences.Recognize each OSC8 control sequence independently and strip only the controls, preserving the displayed text. Update the word wrapper to consume complete control sequences and keep hyperlink state separate from color state; close hyperlinks at cell boundaries and reopen them on continuation lines.
Add regression coverage for colored link text, direct URI changes, standalone opening and closing controls, link IDs containing punctuation, string and byte inputs, table alignment, and wrapped hyperlink text. Update the parser comments and stripping/wrapping docstrings to describe the behavior.
Validation on Linux with Python 3.14.4:
python3 -m build --no-isolation.git diff --checkpassed.Tests ran offline in an isolated filesystem without GitHub credentials. Other Python versions and operating systems have not been tested locally; upstream CI has not run. The build used a shallow checkout, so its generated development version is not release metadata.
Prepared with Codex assistance.