-
-
Notifications
You must be signed in to change notification settings - Fork 3
Implement Service Manager API to set replica mode (#52) #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
83c46e8
Implement Service Manager API to set replica mode (#52)
mariuz 85c2dd8
Rename ConfigManager to DatabaseManager
mariuz 111299a
Format test file DatabaseManager.cpp
mariuz 3b222a1
Address review feedback: rename DatabaseOptions to DatabaseManagerOpt…
mariuz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| /* | ||
| * MIT License | ||
| * | ||
| * Copyright (c) 2026 Popa Adrian Marius | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| * of this software and associated documentation files (the "Software"), to deal | ||
| * in the Software without restriction, including without limitation the rights | ||
| * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| * copies of the Software, and to permit persons to whom the Software is | ||
| * furnished to do so, subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included in all | ||
| * copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| * SOFTWARE. | ||
| */ | ||
|
|
||
| #include "DatabaseManager.h" | ||
| #include "Client.h" | ||
| #include <cassert> | ||
|
|
||
| using namespace fbcpp; | ||
| using namespace fbcpp::impl; | ||
|
|
||
|
|
||
| void DatabaseManager::execute(const DatabaseManagerOptions& options) | ||
| { | ||
| StatusWrapper statusWrapper{getClient()}; | ||
| auto builder = | ||
| fbUnique(getClient().getUtil()->getXpbBuilder(&statusWrapper, fb::IXpbBuilder::SPB_START, nullptr, 0)); | ||
| builder->insertTag(&statusWrapper, isc_action_svc_properties); | ||
| builder->insertString(&statusWrapper, isc_spb_dbname, options.getDatabase().c_str()); | ||
|
|
||
| if (const auto replicaMode = options.getReplicaMode()) | ||
| { | ||
| std::uint8_t modeVal = 0; | ||
| switch (*replicaMode) | ||
| { | ||
| case ReplicaMode::NONE: | ||
| modeVal = isc_spb_prp_rm_none; | ||
| break; | ||
| case ReplicaMode::READ_ONLY: | ||
| modeVal = isc_spb_prp_rm_readonly; | ||
| break; | ||
| case ReplicaMode::READ_WRITE: | ||
| modeVal = isc_spb_prp_rm_readwrite; | ||
| break; | ||
| default: | ||
| assert(false); | ||
| break; | ||
| } | ||
|
mariuz marked this conversation as resolved.
|
||
| builder->insertBytes(&statusWrapper, isc_spb_prp_replica_mode, &modeVal, 1u); | ||
| } | ||
|
|
||
| const auto buffer = builder->getBuffer(&statusWrapper); | ||
| const auto length = builder->getBufferLength(&statusWrapper); | ||
|
|
||
| startAction(std::vector<std::uint8_t>(buffer, buffer + length)); | ||
| waitForCompletion(); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| /* | ||
| * MIT License | ||
| * | ||
| * Copyright (c) 2026 Popa Adrian Marius | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| * of this software and associated documentation files (the "Software"), to deal | ||
| * in the Software without restriction, including without limitation the rights | ||
| * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| * copies of the Software, and to permit persons to whom the Software is | ||
| * furnished to do so, subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included in all | ||
| * copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| * SOFTWARE. | ||
| */ | ||
|
|
||
| #ifndef FBCPP_DATABASE_MANAGER_H | ||
| #define FBCPP_DATABASE_MANAGER_H | ||
|
|
||
| #include "ServiceManager.h" | ||
| #include <optional> | ||
| #include <string> | ||
|
|
||
|
|
||
| /// | ||
| /// fb-cpp namespace. | ||
| /// | ||
| namespace fbcpp | ||
| { | ||
| /// | ||
| /// Represents options used to configure database properties through the service manager. | ||
| /// | ||
| class DatabaseManagerOptions final | ||
| { | ||
| public: | ||
| /// | ||
| /// Returns the database path to be configured. | ||
| /// | ||
| const std::string& getDatabase() const | ||
| { | ||
| return database; | ||
| } | ||
|
|
||
| /// | ||
| /// Sets the database path to be configured. | ||
| /// | ||
| DatabaseManagerOptions& setDatabase(const std::string& value) | ||
| { | ||
| database = value; | ||
| return *this; | ||
| } | ||
|
|
||
| /// | ||
| /// Returns the replica mode. | ||
| /// | ||
| const std::optional<ReplicaMode>& getReplicaMode() const | ||
| { | ||
| return replicaMode; | ||
| } | ||
|
|
||
| /// | ||
| /// Sets the replica mode. | ||
| /// | ||
| DatabaseManagerOptions& setReplicaMode(ReplicaMode value) | ||
| { | ||
| replicaMode = value; | ||
| return *this; | ||
| } | ||
|
|
||
| private: | ||
| std::string database; | ||
| std::optional<ReplicaMode> replicaMode; | ||
| }; | ||
|
|
||
| /// | ||
| /// Executes configuration and maintenance operations through the Firebird service manager. | ||
| /// | ||
| class DatabaseManager final : public ServiceManager | ||
| { | ||
| public: | ||
| using ServiceManager::ServiceManager; | ||
|
|
||
| public: | ||
| /// | ||
| /// Configures database properties using the provided options. | ||
| /// | ||
| void execute(const DatabaseManagerOptions& options); | ||
| }; | ||
| } // namespace fbcpp | ||
|
|
||
|
|
||
| #endif // FBCPP_DATABASE_MANAGER_H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.