Skip to content

Fix plugin#4594

Merged
Torxed merged 4 commits into
archlinux:masterfrom
ScarletEmanu:fix-plugin
Jun 28, 2026
Merged

Fix plugin#4594
Torxed merged 4 commits into
archlinux:masterfrom
ScarletEmanu:fix-plugin

Conversation

@ScarletEmanu

Copy link
Copy Markdown
Contributor

PR Description:

Changes in archinstall/lib/args.py:

  • Arguments: added plugin_url: str | None and changed plugin to Path | None for consistency with creds.
  • CLI: --plugin now uses type=Path (was str); added a new --plugin-url option to specify a remote plugin location.
  • _parse_args: if --plugin is set, loads the plugin from the local path as before. If --plugin-url is set instead, the content is downloaded via the existing _fetch_from_url helper and written to a local temp file via a new _write_plugin_to_temp_file helper, then that local path is passed to load_plugin.

Changes in archinstall/lib/plugins.py:

  • Removed _localize_path and the URL-handling branch in load_plugin and now-unused imports (hashlib, urllib.parse, urllib.request).

Tests and Checks

  • [x ] I have tested the code!

@ScarletEmanu ScarletEmanu requested a review from Torxed as a code owner June 17, 2026 11:21
@ScarletEmanu

Copy link
Copy Markdown
Contributor Author

@svartkanin @codefiles @Torxed anyone of you can review this please. Thanks

@Torxed Torxed left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@Torxed Torxed merged commit cce0c47 into archlinux:master Jun 28, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants