Skip to content

fix(buckets): label the allowed-file-extensions input correctly#2996

Open
singhvishalkr wants to merge 1 commit intoappwrite:mainfrom
singhvishalkr:fix-bucket-settings-placeholder
Open

fix(buckets): label the allowed-file-extensions input correctly#2996
singhvishalkr wants to merge 1 commit intoappwrite:mainfrom
singhvishalkr:fix-bucket-settings-placeholder

Conversation

@singhvishalkr
Copy link
Copy Markdown

Fixes #2443.

The tags input on Storage > Bucket > Settings > Allowed File Extensions is currently rendered as:

<InputTags
    id=`user-labels`
    label=`Labels`
    placeholder=`Select or type user labels`
    bind:tags={extensions} />

which surfaces as Labels / Select or type user labels in the UI even though the field is the list of file extensions that the bucket will accept. The section heading directly above it already says Allowed file extensions and the surrounding state is extensions / updateAllowedExtensions, so the input is the only piece of the section still carrying the copy-paste name from an earlier labels component.

This PR updates the id, label, and placeholder on that InputTags so all three match the field's purpose. No behaviour change -- only the labelling that assistive tech and the placeholder hint read.

Before:

  • id=user-labels, label=Labels, placeholder=Select or type user labels

After:

  • id=allowed-file-extensions, label=Allowed file extensions, placeholder=Select or type file extensions

The previous attempt at this (#2530) was closed before landing; this revision also corrects the id / label alongside the placeholder so screen reader / form-autofill context is consistent with the visible section.

The tags input on Storage > Bucket > Settings > Allowed File Extensions was labelled as `Labels` with a placeholder of `Select or type user labels` and an id of `user-labels`. Swap all three to reflect what the field actually captures, matching the section heading (`Allowed file extensions`) and giving assistive tech a meaningful label.

Fixes appwrite#2443.
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 23, 2026

Greptile Summary

This PR fixes a copy-paste labelling issue on the InputTags component in the bucket settings page, updating the id, label, and placeholder from stale "user-labels"/"Labels"/"Select or type user labels" values to the semantically correct "allowed-file-extensions"/"Allowed file extensions"/"Select or type file extensions". The change is purely cosmetic and improves accessibility (screen reader labelling and form-autofill context) with zero behaviour impact.

Confidence Score: 5/5

Safe to merge — single-file, text-only fix with no logic or behavioural changes.

All three changed lines are string literals in a template; no logic, state, or API surface is affected. No P0/P1 findings.

No files require special attention.

Important Files Changed

Filename Overview
src/routes/(console)/project-[region]-[project]/storage/bucket-[bucket]/settings/+page.svelte Corrects the id, label, and placeholder on the allowed-file-extensions InputTags from stale copy-paste labels ("user-labels" / "Labels" / "Select or type user labels") to semantically accurate values; no logic changes.

Reviews (1): Last reviewed commit: "fix(buckets): label the allowed-file-ext..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible typo in Storage > Bucket > Settings page

1 participant