You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds SSR startCommand support across the Sites creation and settings flows — centralizing the FrameworkAdapterWithStartCommand type in sites.ts, plumbing startCommand through the uploader, all sites.update passthrough calls, and the UI (SSR-gated input in configuration.svelte and updateBuildSettings.svelte). Previously flagged issues (duplicate type definition, missing startCommand in uploadSiteDeployment for the manual upload flow, and inconsistent null-coalescing on Reset buttons) are all resolved in this iteration.
Confidence Score: 5/5
Safe to merge — all previously reported issues are resolved and startCommand is consistently propagated across every relevant code path.
No P0 or P1 findings remain. The type is centralized, the uploader accepts and forwards startCommand, all passthrough sites.update calls preserve it, and the UI correctly gates the field behind adapter === Adapter.Ssr.
No files require special attention.
Important Files Changed
Filename
Overview
src/lib/stores/sites.ts
Adds the shared FrameworkAdapterWithStartCommand type, resolving the previously noted duplicate-type issue across five files.
src/lib/stores/uploader.ts
Adds startCommand to uploadSiteDeployment signature and forwards it in the deployment payload; small refactor to extract deploymentPayload object is clean.
SSR-gated start command input added with consistent null-coalescing on Reset disabled condition; startCommand included in isUntouched derived and update payload.
SSR-gated start command field added with null-coalescing guards applied consistently to all three Reset button conditions.
src/routes/(public)/sites/deploy/+page.svelte
Start command field and URL param forwarding added to the public deploy-button flow; startCommand is included in sites.create and piped through URL query params.
CSS restructuring moves max-width: 36rem from .protocols-list to .protocol-list-content so the toolbar can expand full-width; wraps the divider in a container div.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)