Skip to content

feat:add SSR start command support for sites#2990

Open
HarshMN2345 wants to merge 3 commits intomainfrom
fix-ssr-start-command-sites
Open

feat:add SSR start command support for sites#2990
HarshMN2345 wants to merge 3 commits intomainfrom
fix-ssr-start-command-sites

Conversation

@HarshMN2345
Copy link
Copy Markdown
Member

What does this PR do?

image

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 22, 2026

Greptile Summary

This PR adds SSR startCommand support across the Sites creation and settings flows — centralizing the FrameworkAdapterWithStartCommand type in sites.ts, plumbing startCommand through the uploader, all sites.update passthrough calls, and the UI (SSR-gated input in configuration.svelte and updateBuildSettings.svelte). Previously flagged issues (duplicate type definition, missing startCommand in uploadSiteDeployment for the manual upload flow, and inconsistent null-coalescing on Reset buttons) are all resolved in this iteration.

Confidence Score: 5/5

Safe to merge — all previously reported issues are resolved and startCommand is consistently propagated across every relevant code path.

No P0 or P1 findings remain. The type is centralized, the uploader accepts and forwards startCommand, all passthrough sites.update calls preserve it, and the UI correctly gates the field behind adapter === Adapter.Ssr.

No files require special attention.

Important Files Changed

Filename Overview
src/lib/stores/sites.ts Adds the shared FrameworkAdapterWithStartCommand type, resolving the previously noted duplicate-type issue across five files.
src/lib/stores/uploader.ts Adds startCommand to uploadSiteDeployment signature and forwards it in the deployment payload; small refactor to extract deploymentPayload object is clean.
src/routes/(console)/project-[region]-[project]/sites/create-site/manual/+page.svelte Correctly passes startCommand to both sites.create and uploader.uploadSiteDeployment, addressing the previously reported P1 gap.
src/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/updateBuildSettings.svelte SSR-gated start command input added with consistent null-coalescing on Reset disabled condition; startCommand included in isUntouched derived and update payload.
src/routes/(console)/project-[region]-[project]/sites/create-site/configuration.svelte SSR-gated start command field added with null-coalescing guards applied consistently to all three Reset button conditions.
src/routes/(public)/sites/deploy/+page.svelte Start command field and URL param forwarding added to the public deploy-button flow; startCommand is included in sites.create and piped through URL query params.
src/routes/(console)/project-[region]-[project]/settings/updateProtocols.svelte CSS restructuring moves max-width: 36rem from .protocols-list to .protocol-list-content so the toolbar can expand full-width; wraps the divider in a container div.
src/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/updateName.svelte Passthrough update call now includes startCommand: site?.startCommand so the field is not silently cleared when name is updated.
src/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/updateRuntimeSettings.svelte Passthrough sites.update call now includes startCommand, preventing it from being dropped on runtime updates.
src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/createGitDeploymentModal.svelte Pre-existing site update call now preserves startCommand when connecting a repository for the first time before creating a Git deployment.

Reviews (3): Last reviewed commit: "added command in uploader" | Re-trigger Greptile

@HarshMN2345 HarshMN2345 requested a review from Meldiron April 22, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant