Repository navigation
fix(typing): refine WebDriver, WebElement, MobileSwitchTo, and AppiumBy type annotations - #1357
Merged
Merged
Conversation
…By type annotations
KazuCocoa
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1147
Summary
MobileSwitchTo.active_elementreturn type annotation toWebElementso callers get Appium mobile element typing without manual casts.byparameter type onWebDriverandWebElementfind methods to accept Selenium locator enums alongside string values, matching the protocol signatures.ByTypeannotations toAppiumByconstants so type checkers preserve narrow locator literal types, and remove redundant casts inFlutterFinder.Testing
uv run mypy --warn-unused-ignores appiumuv run ruff check .make check-formatmake unittest(227 passed)