Skip to content

fix: preserve default locator strategy in WebDriver type hints #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KazuCocoa merged 4 commits into from
Sep 10, 2026
Merged

fix: preserve default locator strategy in WebDriver type hints #1298

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
900741d
fix: preserve default locator strategy in WebDriver type hints
MattL1989 Sep 8, 2026
80f66db
test: cover default and explicit WebDriver locator type hints
MattL1989 Sep 8, 2026
667ee88
style: preserve existing source line endings
MattL1989 Sep 8, 2026
26824aa
refactor: import By under TYPE_CHECKING and drop type-hint test
MattL1989 Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions appium/webdriver/webdriver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@
from .switch_to import MobileSwitchTo
from .webelement import WebElement as MobileWebElement

if TYPE_CHECKING:
from selenium.webdriver.common.by import By


class ExtensionBase:
"""
Expand Down Expand Up @@ -281,10 +284,10 @@ def __init__(

if TYPE_CHECKING:

def find_element(self, by: str, value: str | dict | None = None) -> 'MobileWebElement': # type: ignore[override]
def find_element(self, by: str = By.ID, value: str | dict | None = None) -> 'MobileWebElement': # type: ignore[override]
...

def find_elements(self, by: str, value: str | dict | None = None) -> list['MobileWebElement']: # type: ignore[override]
def find_elements(self, by: str = By.ID, value: str | dict | None = None) -> list['MobileWebElement']: # type: ignore[override]
...

def delete_extensions(self) -> None:
Expand Down
Loading