Repository navigation
Conversation
Convert the 500ms polling interval to seconds before calling is_service_listening. The complete patch passed 175 unit tests, Ruff, formatting, Mypy and local HTTP200/503 smoke checks. Individual HTTP timeout/retry behavior is unchanged.
Exercise the public is_listening property through the real polling helper with a simulated clock and HTTP200/503 responses. The regression observes 500 seconds before the fix and 0.5 seconds afterward. All 175 unit tests and make check passed.
KazuCocoa
approved these changes
Sep 8, 2026
Member
|
Hi @lucasmariano003-wq, congrats: the Appium project wants to compensate you for this contribution! Please reply to this comment mentioning @jlipps and @KazuCocoa and sharing your OpenCollective account name, so that we can initiate payment! Or let us know if you decline to receive compensation via OpenCollective. Thank you! |
Contributor
Author
|
Hi @jlipps and @KazuCocoa, thank you very much! My OpenCollective account is https://opencollective.com/account-9abfc49d (handle: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AppiumService.is_listeningpassesSTATE_CHECK_INTERVAL_MSdirectly tois_service_listening, whose timeout is in seconds. When the service process remains alive but its status endpoint is unavailable, the polling budget is therefore 500 seconds instead of 500 milliseconds.Convert the interval to seconds, consistently with the service startup path. This restores the intended polling budget; individual HTTP request timeouts and retries are unchanged and may extend the overall call duration.
Validation
is_listeningthrough the real polling helper with a simulated clock. Before the fix, HTTP503 advanced the clock by 500 seconds; afterward it advances by 0.5 seconds. HTTP200 still returns immediately.Falsein 0.503 seconds afterward. HTTP200 returnedTruein 0.001 seconds.make checkpassed: Ruff, formatting, and Mypy over 320 source files.OpenAI Codex performed the implementation and local validation for this GitHub account; maintainer review is pending.
If accepted, please confirm whether this PR qualifies for compensation under the Appium contributor compensation scheme and the applicable amount. I understand that classification and payment remain at the project's discretion.