Skip to content

ADFA-365 - project build test with Bottom navigation Drawer Project - #6

Merged
romanlapa merged 1 commit into
stagefrom
feature/ADFA-365-bottom-navigation
Feb 12, 2025
Merged

romanlapa merged 1 commit into
stagefrom
feature/ADFA-365-bottom-navigation

Conversation

@YahorZCzygunki

Copy link
Copy Markdown
Contributor

No description provided.

@romanlapa
romanlapa merged commit 5ff2b71 into stage Feb 12, 2025
@hal-eisen-adfa
hal-eisen-adfa deleted the feature/ADFA-365-bottom-navigation branch July 4, 2025 16:40
jatezzz pushed a commit that referenced this pull request Jun 22, 2026
ADFA-365 - project build test with Bottom navigation Drawer Project
jatezzz added a commit that referenced this pull request Jul 17, 2026
Fan-out, adapter, and plugin-API fixes from the ProjectSearchExtension review:

- Guard plugin results against null elements (mapNotNull) and wrap the collection block in a logging try/catch so a bad element no longer kills the whole fan-out silently. (#1)
- buildRows buffers each section's rows and emits the header only when a group exists, skipping blank titles -- no more orphan/blank headers suppressing the empty state. (#2)
- Move the fan-out to lifecycleScope so a slow plugin can't pin a destroyed Activity/ViewModel or post to a dead Activity. (#3)
- Keep the search progress indicator up when the built-in search is empty but plugins are enabled, so a plugin-only match doesn't flash a terminal "no results" state. (#4)
- SearchListAdapter is now a ListAdapter + DiffUtil reused across emissions; the two-phase publish diffs instead of reallocating, preserving scroll and already-run highlights. (#5)
- Collapse the adapter constructors to one clicks ctor plus a thin map convenience ctor; drop the dead keys param and nullable-value scrub. (#6)
- Replace the blocking .get(10s) with a non-blocking withTimeoutOrNull + await so no commonPool worker is tied up. (#7)
- Trim pipe-split filter tokens at the source (endsWith(" kt") matched nothing in built-in search too); align ProjectSearchExtension KDoc with actual behavior and drop the non-ASCII em-dash. (#9, #10)
jatezzz added a commit that referenced this pull request Jul 20, 2026
Fan-out, adapter, and plugin-API fixes from the ProjectSearchExtension review:

- Guard plugin results against null elements (mapNotNull) and wrap the collection block in a logging try/catch so a bad element no longer kills the whole fan-out silently. (#1)
- buildRows buffers each section's rows and emits the header only when a group exists, skipping blank titles -- no more orphan/blank headers suppressing the empty state. (#2)
- Move the fan-out to lifecycleScope so a slow plugin can't pin a destroyed Activity/ViewModel or post to a dead Activity. (#3)
- Keep the search progress indicator up when the built-in search is empty but plugins are enabled, so a plugin-only match doesn't flash a terminal "no results" state. (#4)
- SearchListAdapter is now a ListAdapter + DiffUtil reused across emissions; the two-phase publish diffs instead of reallocating, preserving scroll and already-run highlights. (#5)
- Collapse the adapter constructors to one clicks ctor plus a thin map convenience ctor; drop the dead keys param and nullable-value scrub. (#6)
- Replace the blocking .get(10s) with a non-blocking withTimeoutOrNull + await so no commonPool worker is tied up. (#7)
- Trim pipe-split filter tokens at the source (endsWith(" kt") matched nothing in built-in search too); align ProjectSearchExtension KDoc with actual behavior and drop the non-ASCII em-dash. (#9, #10)
jatezzz added a commit that referenced this pull request Jul 20, 2026
…#1528)

* feat(search): add ProjectSearchExtension API for plugin result sections
Fan out to enabled plugins after built-in search and render their sections.

* style: apply spotless formatting to search extension files

* fix(search): address review findings on plugin search extension

- Bound plugin search fan-out with a 10s timeout and drop results from superseded searches via a generation counter in EditorViewModel
- Guard against Java plugins completing their future with null
- Flatten SearchListAdapter's nested RecyclerView into Row.Match rows so match rows recycle instead of inflating all at once
- Narrow catch(Throwable) to catch(Exception) per REVIEW.md
- Document plugin-api search contract types; coordinates are 0-based, end-exclusive
- Marshal plugin crash recording to the UI thread and drop the unread searchResults flow.

* fix(search): address review feedback on search results list

- Make the group row's LinearLayout the layout root so the click listener on binding.root receives taps (the clickable child was consuming them) and drop the redundant RelativeLayout wrapper
- Log highlight failures via SLF4J and keep the plain-text preview instead of overwriting the line with the matched text
- Skip files with empty match lists to avoid dangling group headers
- Hide the decorative file icon from accessibility services

* fix(search): address code-review findings on plugin search

Fan-out, adapter, and plugin-API fixes from the ProjectSearchExtension review:

- Guard plugin results against null elements (mapNotNull) and wrap the collection block in a logging try/catch so a bad element no longer kills the whole fan-out silently. (#1)
- buildRows buffers each section's rows and emits the header only when a group exists, skipping blank titles -- no more orphan/blank headers suppressing the empty state. (#2)
- Move the fan-out to lifecycleScope so a slow plugin can't pin a destroyed Activity/ViewModel or post to a dead Activity. (#3)
- Keep the search progress indicator up when the built-in search is empty but plugins are enabled, so a plugin-only match doesn't flash a terminal "no results" state. (#4)
- SearchListAdapter is now a ListAdapter + DiffUtil reused across emissions; the two-phase publish diffs instead of reallocating, preserving scroll and already-run highlights. (#5)
- Collapse the adapter constructors to one clicks ctor plus a thin map convenience ctor; drop the dead keys param and nullable-value scrub. (#6)
- Replace the blocking .get(10s) with a non-blocking withTimeoutOrNull + await so no commonPool worker is tied up. (#7)
- Trim pipe-split filter tokens at the source (endsWith(" kt") matched nothing in built-in search too); align ProjectSearchExtension KDoc with actual behavior and drop the non-ASCII em-dash. (#9, #10)

* style(search): expand when branches to block form for ktlint

Spotless ratchets from origin/stage; stage was reformatted after this branch diverged, so CI flagged the single-expression when branches in onUpdateWadbConnectionStatus and the multi-line FileOpResult.Success branch. Expand them to ktlint's canonical block form so the file is fully canonical and passes under any ratchet base.

* fix: reported violations for spotless
davidschachterADFA added a commit that referenced this pull request Nov 12, 2026
…ixes

Patch 0008 (terminal-packages PR #6, sqlite-js 1.3.7-3) makes next() and
toArray() throw when the statement fails. Before it, next() returned
false and toArray() returned the rows before the error. The javascript
page now says so, with a tested example that catches a failed UNIQUE
insert. The example fails on a host build without 0008. The functions
page lists the eighth fix.

CLAIMS.md: test_examples.py passes 35 of 35 on a host build of 1.3.7-4.
Phone results: 1.3.7-2 passed 87 of 87, which closes the
js_set_max_stack_size TODO. 1.3.7-3 and 1.3.7-4 passed 91 of 91 on
aarch64 and on arm, run as a 32-bit process.

README: the pages document 1.3.7-3 and later.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vh2DAXGyHbMzjSsi2zbrkw
davidschachterADFA added a commit that referenced this pull request Nov 12, 2026
Patches 0002, 0003, 0004 and 0010 are regenerated after three reviews:
the independent reviews of terminal-packages #6 and of this PR, and
CodeRabbit's review of this PR.
- 0002: garbage is collected before the memory limit fills. Running
  out of memory through small allocations reports "out of memory".
- 0003: the README says TEMP views and triggers can call the js_*
  functions.
- 0004: db.exec throws for a buffer it cannot read instead of binding
  NULL. A typed array's own offset and length are used, not properties
  a script defines.
- 0010: a cancel also interrupts the cancelled call's statement, so a
  runaway JavaScript collation stops. Before, nothing could stop one.

The other patches change only in their headers and line numbers.
upstream/ is regenerated with vendor.sh, and vendor.sh --check passes.
SqliteJs.cancelAll() and the README say a cancel interrupts the
statement too.

Tested:
- test.sh: upstream's suite passes 16 of 16, and the glue test 16 of 16.
- In the work repo, the same suite passes under ASan and UBSan with
  leak checking, and each new test fails without its fix.
- The AAR builds for arm64-v8a and armeabi-v7a.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vh2DAXGyHbMzjSsi2zbrkw
davidschachterADFA added a commit that referenced this pull request Nov 12, 2026
Upstream released 1.4.0 and 1.4.1 on 2026-11-12. Both contain c8ae85a,
and their C code differs from it only in the version string, so the
terminal package moves to 1.4.1 (terminal-packages #6). That answers both
comments from the independent review:

- Overview page, README.md and CLAIMS.md: the pages now describe 1.4.1
  and later. "1.3.7-3 and later" was wrong: 1.3.7-3 to 1.3.7-5 lack the
  fix for a lowered memory limit (upstream ef06558).
- Functions page: js_version() gives 1.4.1, so the note that a newer
  package still reports 1.3.7 is gone. The last section is now "What
  changed in sqlite-js 1.4" and says that 1.4.0 includes our fixes.
- CLAIMS.md: the probes that cited older builds were run again on 1.4.1,
  with the same results: redefinition, js_init_table(1) twice,
  js_set_max_stack_size's inputs and recursion, the held-memory limit,
  db.exec errors and variable sharing.

test_examples.py: 64 of 64 on a host build of 1.4.1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vh2DAXGyHbMzjSsi2zbrkw
davidschachterADFA added a commit that referenced this pull request Nov 12, 2026
0002, after CodeRabbit's review: code that called itself without end
crashed the process instead of failing with "Maximum call stack size
exceeded" in two cases.
- On a thread with less than 64 KB of stack left, js_enter kept the
  connection's 1 MB size rather than the room it measured. It now keeps
  any measurement, and 1 rather than 0, which turns the check off.
- On the main thread, RLIMIT_STACK was counted from where the first
  measurement was taken. Loaded 2 MB deep, the extension allowed 10.2 MB
  of an 8 MB stack. It is now counted from the stack's top, as the
  kernel counts it.

0003, after the independent review of terminal-packages #6: garbage
could leave an allocation that fits in the memory limit failing on every
try. After 40 MB of cyclic garbage, new ArrayBuffer(30 MB) failed under
the 64 MB default. And after a limit was lowered to 32 MB above the
garbage, new ArrayBuffer(16 MB) failed. The extension now collects
after any "out of memory" error and whenever a limit is set.

Each patch adds tests to upstream's suite that fail without it. The
suite passes 16 of 16 with all three patches, also under ASan and UBSan,
and test.sh's glue_test 22 of 22. The NDK 29 build for arm64-v8a and
armeabi-v7a has no warnings outside QuickJS and exports the same four
symbols. Both fixes are offered upstream.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vh2DAXGyHbMzjSsi2zbrkw
davidschachterADFA added a commit that referenced this pull request Nov 12, 2026
The terminal package is 1.4.1 with two patches (terminal-packages #6):
the stack check and garbage collection. test_examples.py passes 64 of 64
on a host build with them, as on 1.4.1 without them, and no page claim
changes. CLAIMS says so. The pages and the test database are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vh2DAXGyHbMzjSsi2zbrkw
davidschachterADFA added a commit that referenced this pull request Nov 16, 2026
terminal-packages #6 revision 2 (the review's test fixes) is on stage,
and the phone reports 1.4.2-2 after the upgrade from 1.4.2-1. The pages
say 1.4.2 and later, so they are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vh2DAXGyHbMzjSsi2zbrkw
davidschachterADFA added a commit that referenced this pull request Nov 17, 2026
Revision 3 of the sqlite-js terminal package carries the independent
review's test fixes; its library is unchanged. Stage's 1.4.2-3 installs
on the phone and reports that version. The package reaches main through
terminal-packages #7, since #6 merged into an already-merged base.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vh2DAXGyHbMzjSsi2zbrkw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants