Repository navigation
ADFA-6650: Keep Shizuku entry points and callbacks through R8 - #2166
Merged
Merged
Conversation
Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>
…ir classes Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
Daniel-ADFA
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADFA-6650
Wireless-debugging pairing has been broken in every release build since 26.36: pairing succeeds, but the Shizuku server dies on startup, so Debug keeps showing the pairing dialog. The experimental profiler is broken the same way. Debug builds are unaffected because they are not minified.
Cause
ADFA-5195 (#1701,
8d526ac586) removed-dontshrink, turning R8 shrinking back on for the whole app. Shizuku runs code R8 can't trace from the app, so it was stripped or rewritten:ShizukuService.main,ServiceStarter.mainapp_processClassNotFoundExceptionin the serverProfilerUserServiceconstructorsComponentNameclass nameAbstractMethodErroron the first callbackIPackageManager, ...)profilerandprivileged-servicespackaged the hidden-API stubs, so R8 saw interfaces with no implementations and rewrote the calls tothrow nullMANAGER_APP_NOT_FOUND(status 50); 11 other hidden-API calls also became throwsBisected via the shipped APKs (26.35 has the server classes, 26.36 does not) and local R8 builds of
8d526ac586and its parent.Changes
profilerandprivileged-services: hidden-API stubsimplementation->compileOnly, matching every other Shizuku module.consumer-rules.proinshizuku-serverandshizuku-starter, and rules in the previously empty one inprivileged-services:app_processentry points andProfilerUserService's constructors;rikka.hidden.compat.adapter.**public members and their subclasses' overrides. The rules name the adapters because their hidden-API superclasses are compile-only and invisible to R8.Verification
Built
:app:assembleV8Profileable(same R8 configuration as release) and checked the dex:ShizukuService,ServiceStarter,UserServiceand a populatedProfilerUserServiceare present.BinderSenderandProfilerUserServiceare present.Shizuku.scheduleBinderDeadListeners, which is unreachable: nothing registers a binder-dead listener.No UI changes, so no font-scale check.