Repository navigation
ADFA-4606: Improve output panel screen reader activation #1539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
makhlwf
wants to merge
1
commit into
appdevforall:stage
Choose a base branch
from
makhlwf:community/ADFA-4606-output-panel-accessibility
base: stage
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -360,6 +360,10 @@ | |
| <string name="xml_validation_error_generic">We could not open this layout. Fix the XML and try again.</string> | ||
| <string name="title_generating_xml">Generating XML code</string> | ||
| <string name="msg_swipe_up">Swipe up to display logs, diagnostics, debug info, and more</string> | ||
| <string name="cd_build_status_output_panel_empty">Build status. %1$s.</string> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The action-label placeholder is redundant here. Could you please remove |
||
| <string name="cd_build_status_output_panel">Build status: %1$s. %2$s.</string> | ||
| <string name="action_expand_output_panel">Open output panel</string> | ||
| <string name="action_collapse_output_panel">Close output panel</string> | ||
| <string name="preview_render_error_title">Preview Unavailable</string> | ||
| <string name="preview_render_error_message">Could not create a root view. The XML is empty or missing a valid top-level element.</string> | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this breaks tap-to-expand for touch users. Could you please re-add a standard
OnClickListenertobuildStatusLayoutso the toggle works for all users?With that in place,
ACTION_CLICKcan also be removed from theperformAccessibilityActionblock, allowingsuper.performAccessibilityActionto handle it natively.This should work: