feat: skip role chaining when awsRoleArn is empty - #318
Merged
Conversation
github-actions
Bot
added
the
t-infra
markubra
force-pushed
the
feat/optional-role-chaining
branch
from
August 25, 2026 11:34
0c1ff61 to
29a33c8
Compare
seyhello
approved these changes
Aug 25, 2026
markubra
pushed a commit
that referenced
this pull request
Aug 25, 2026
🤖 I have created a release *beep* *boop* --- ## [0.49.0](v0.48.1...v0.49.0) (2026-08-25) ### Features * add reusable workflow that keeps AGENTS.md accurate in the PR that changed it ([#311](#311)) ([a333e4d](a333e4d)) * skip role chaining when awsRoleArn is empty ([#318](#318)) ([d62affa](d62affa)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
assume Deployer rolestep runs wheneveruseOIDC: true, so a caller whose OIDC role already carries the permissions has no way to use OIDC - the step fails with an emptyrole-to-assume. Skipping it whenawsRoleArnis empty lets a purpose-scoped OIDC role push directly, without standing up a second role just to satisfy the chain.awsRoleArn.GithubIntegrationsOIDCRoleis scoped toecr:*on the integrations repositories.