Skip to content

fix(templates): Decouple the Camoufox Playwright pin - #2183

Closed
ousamabenyounes wants to merge 2 commits into
apify:masterfrom
ousamabenyounes:fix/issue-2175
Closed

fix(templates): Decouple the Camoufox Playwright pin#2183
ousamabenyounes wants to merge 2 commits into
apify:masterfrom
ousamabenyounes:fix/issue-2175

Conversation

@ousamabenyounes

@ousamabenyounes ousamabenyounes commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Description

  • Give Camoufox an explicit Playwright 1.60.0 compatibility pin instead of following the shared updater pin.
  • Resolve the shared pin only from the standard Playwright image variants.
  • Validate that Camoufox's exact pinned image tag is published without automatically bumping it.

Issues

Testing

  • uv run pytest tests/unit/scripts/test_update_playwright_version.py
  • ./run-ci.sh

Test verification (RED → GREEN)

Upstream master with the reproduction test and published 3.13-1.61.0 tag:

Bumped Playwright version: 1.60.0 -> 1.61.0
FAILED test_camoufox_keeps_compatible_playwright_pin
assert 'playwright==1.60.0' in rendered
1 failed

Patched branch:

tests/unit/scripts/test_update_playwright_version.py ......... [100%]
9 passed
run-ci: ALL JOBS PASSED

Checklist

  • CI passed

@vdusek vdusek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait for @Pijukatel approval since he knows this part better

@vdusek
vdusek requested a review from Pijukatel August 24, 2026 10:18
@Pijukatel

Copy link
Copy Markdown
Collaborator

Thanks for the PR, but we decided to merge a more limited change: #2189

@Pijukatel Pijukatel closed this Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Playwright bump script ignores base image variants, breaking camoufox e2e

5 participants