test: Extend e2e tests - #11
Open
Mantisus wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Extends the E2E coverage to validate the sensor across more real-world runtime environments (ARM64 runners, podman rootless/rootful, and additional Docker/Kubernetes resource-shaping cases) and refactors the E2E harness to support multiple container engines cleanly.
Changes:
- Add a dedicated podman E2E suite (rootless + rootful) and supporting harness abstractions.
- Expand Docker and Kubernetes E2E scenarios to cover additional limit/request shapes and tricky cgroup layouts.
- Extend CI and guest VM setup to run the new lanes (ARM job, podman job, guest profile tweaks) and document new pytest markers.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
tests/e2e/test_podman.py |
New podman E2E coverage for rootless/rootful behaviors and delegation-dependent cases. |
tests/e2e/test_kubernetes.py |
Adds pod resource scenarios (Guaranteed QoS, CPU-only, memory-only) to validate limit detection. |
tests/e2e/test_docker.py |
Adds Docker scenarios for CPU shares and namespace/mount edge cases to harden limit/rate interpretation. |
tests/e2e/scripts/guest.sh |
Updates guest profiles and cloud-init setup to support podman lane and docker group handling. |
tests/e2e/harness.py |
Introduces multi-engine support (Engine), command construction helpers, and registry qualification. |
tests/e2e/conftest.py |
Adds session fixtures for podman image pulls and new systemd slice fixtures. |
pyproject.toml |
Adds/updates pytest markers to cover podman and clarify systemd_slices. |
.github/workflows/e2e.yaml |
Adds ARM64 and podman CI jobs and required environment setup for rootless podman. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
45
to
47
| name = f'cgroups-sensor-e2e-{os.getpid()}.slice' | ||
| holder = f'cgroups-sensor-e2e-holder-{os.getpid()}' | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #5