Skip to content

feat: add Actor task publication endpoints - #985

Open
apify-service-account wants to merge 5 commits into
masterfrom
update-models-docs-pr-2840
Open

feat: add Actor task publication endpoints#985
apify-service-account wants to merge 5 commits into
masterfrom
update-models-docs-pr-2840

Conversation

@apify-service-account

Copy link
Copy Markdown
Contributor
  • Updates the auto-generated Pydantic models and TypedDicts based on the proposed OpenAPI specification changes.
  • Based on apify-docs PR #2840.

@apify-service-account apify-service-account added the t-tooling Issues with this label are in the ownership of the tooling team. label Aug 2, 2026
@codecov

codecov Bot commented Aug 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.89%. Comparing base (a6ca0cb) to head (a45e4ad).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
src/apify_client/_typeddicts.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #985      +/-   ##
==========================================
+ Coverage   94.71%   94.89%   +0.18%     
==========================================
  Files          58       58              
  Lines        5337     5391      +54     
==========================================
+ Hits         5055     5116      +61     
+ Misses        282      275       -7     
Flag Coverage Δ
integration 92.24% <84.21%> (+0.05%) ⬆️
unit 85.17% <94.73%> (+0.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Janjiran Janjiran changed the title TODO feat: add Actor task publication endpoints Aug 3, 2026

@vdusek vdusek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let's merge this once the PRs in apify-core and apify-docs are merged.

@vdusek
vdusek marked this pull request as draft August 3, 2026 14:40
@Janjiran
Janjiran marked this pull request as ready for review August 10, 2026 14:21
@Janjiran
Janjiran requested a review from vdusek August 10, 2026 14:21
@Janjiran Janjiran added this to the 146th sprint - Growth team milestone Aug 10, 2026
@vdusek

vdusek commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Please resolve the failing CI

Janjiran and others added 2 commits August 10, 2026 16:59
The models committed earlier came from a superseded revision of the spec
PR that used dedicated publish/unpublish endpoints. The current revision
puts `isPublic` on the update request instead, which is what the client
code and tests were written against. Also merges master and syncs the
async create docstring.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Y6GXQXFZK4XoGwNgXHkk1n

@vdusek vdusek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things, mostly minor test and docs-related stuff.

Marking this as "request changes" since it should be merged after the upstream PR. Also, we probably want to release one more patch version of the client before the next minor release.



@docs_group('Models')
class TaskPublicConfig(BaseModel):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These models come from a spec that is not merged and deployed - Let's wait for the merge of apify/apify-docs#2840.

Comment thread tests/unit/test_task_publication.py
Comment thread src/apify_client/_resource_clients/task_collection.py Outdated
Comment thread tests/unit/test_task_publication.py Outdated
Comment thread tests/unit/test_task_publication.py Outdated
Comment thread src/apify_client/_resource_clients/task_collection.py Outdated
Comment thread src/apify_client/_resource_clients/task_collection.py Outdated
Comment thread tests/unit/test_task_publication.py Outdated
Comment thread tests/unit/test_task_publication.py Outdated
Comment thread tests/unit/test_task_publication.py Outdated
@Janjiran
Janjiran requested a review from vdusek August 12, 2026 14:26

@vdusek vdusek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, just let's merge it after a next patch version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants