feat: Unify the request pipeline across HTTP clients - #1011
Draft
vdusek wants to merge 1 commit into
Draft
Conversation
vdusek
added
adhoc
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1011 +/- ##
==========================================
+ Coverage 94.87% 94.91% +0.03%
==========================================
Files 58 58
Lines 5367 5385 +18
==========================================
+ Hits 5092 5111 +19
+ Misses 275 274 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
force-pushed
the
move-http-pipeline-to-base
branch
from
August 17, 2026 20:30
e6f24c5 to
4d7112b
Compare
github-actions
Bot
added
the
tested
vdusek
changed the title
vdusek
force-pushed
the
move-http-pipeline-to-base
branch
from
August 18, 2026 09:20
eaeb849 to
a4ae1e6
Compare
This was referenced Aug 18, 2026
vdusek
added a commit
that referenced
this pull request
Aug 18, 2026
Every `impit.HTTPError` counted as transient, so a transport failure a retry cannot fix burned the whole backoff before surfacing. The permanent classes now fail on the first attempt instead: - `LocalProtocolError` - a request Impit rejects before sending it, e.g. one carrying an invalid header value. - `TooManyRedirects` - a routing loop, which repeating the request cannot break. - `UnsupportedProtocol` - the class Impit declares for a scheme it refuses to speak, but does not raise today; an unsupported scheme arrives as `impit.InvalidURL`, outside the `impit.HTTPError` tree and non-retryable already. Listed so the classifier stays right if Impit switches over. - `HTTPStatusError` - only `Response.raise_for_status()` raises it and the client never calls it; `_make_request` decides on status codes from the response itself. Everything else in the `impit.HTTPError` tree stays retryable, including a bare `HTTPError` - Impit wraps a failure its internal HTTP library did not classify in one, e.g. a non-HTTP response or a connection reset - and a `ProxyError`, which covers a rejected CONNECT tunnel and a 407 alike, so a transient case cannot be told from a permanent one. Also drops `InvalidResponseBodyError` from the retry check. Only `key_value_store.py` raises it, once `call` has already returned, so it can never reach the classifier. Its docstring no longer claims the client retries such requests. The duplicate `is_retryable_error` in `_utils/errors.py`, which carried the old policy, is gone. Split out of #1006 and re-targeted at `master`, so the retry fixes can ship in a patch release ahead of the pipeline refactor in #1011. *✍️ Drafted by Claude Code*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
call, the retry loop, and the per-attempt request handling fromImpitHttpClientandImpitHttpClientAsyncintoHttpClientandHttpClientAsync, leaving Impit as a thin adapter over the transport hooks:send_request,is_retryable_transport_error,is_timeout_error, andclose()/aclose()plus context managers. A custom client that overridescallkeeps working unchanged and opts out of the shared pipeline.StreamedLogclassifies timeouts through the transport-neutralis_timeout_errorhook instead of importing Impit.No behavior change for the built-in clients: retry classification stays exactly as on master (every
impit.HTTPErroris transient). The classification fixes follow in #1012.Split out of #1006.
✍️ Drafted by Claude Code