[ZEPPELIN-6370] Upgrade playwright and change the method of installing Playwright browsers#5108
Merged
Merged
Conversation
tbonelee
approved these changes
Oct 24, 2025
tbonelee
pushed a commit
that referenced
this pull request
Oct 24, 2025
…g Playwright browsers ### What is this PR for? #5107 https://github.com/apache/zeppelin/actions/runs/18662031473/job/53204596550?pr=5107 In the Playwright E2E tests of the above bump PR, the following issue occurred: ``` Error: browserType.launch: Executable doesn't exist at /home/runner/.cache/ms-playwright/webkit-2215/pw_run.sh ``` This issue seems to be caused by the Playwright browser installation step being version-locked in `zeppelin-web-angular/pom.xml`'s playwright-install execution. Instead of managing it in `pom.xml`, it would be better to add it to the `postinstall` script in `zeppelin-web-angular/package.json`, so that Playwright browsers are automatically installed when running `npm install`, either in CI and on a local environment. This PR addresses that change. 61ff629 Including the CI caching procedure as above, it seems optimized as previous approach(pom.xml). ### What type of PR is it? Improvement ### Todos ### What is the Jira issue? ZEPPELIN-6370 ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #5108 from dididy/e2e/upgrade-playwright. Signed-off-by: ChanHo Lee <chanholee@apache.org> (cherry picked from commit 0a768bc) Signed-off-by: ChanHo Lee <chanholee@apache.org>
Contributor
|
Merged into master and branch-0.12 |
voidmatcha
added a commit
to voidmatcha/zeppelin
that referenced
this pull request
Oct 26, 2025
…g Playwright browsers apache#5107 https://github.com/apache/zeppelin/actions/runs/18662031473/job/53204596550?pr=5107 In the Playwright E2E tests of the above bump PR, the following issue occurred: ``` Error: browserType.launch: Executable doesn't exist at /home/runner/.cache/ms-playwright/webkit-2215/pw_run.sh ``` This issue seems to be caused by the Playwright browser installation step being version-locked in `zeppelin-web-angular/pom.xml`'s playwright-install execution. Instead of managing it in `pom.xml`, it would be better to add it to the `postinstall` script in `zeppelin-web-angular/package.json`, so that Playwright browsers are automatically installed when running `npm install`, either in CI and on a local environment. This PR addresses that change. 61ff629 Including the CI caching procedure as above, it seems optimized as previous approach(pom.xml). Improvement ZEPPELIN-6370 * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes apache#5108 from dididy/e2e/upgrade-playwright. Signed-off-by: ChanHo Lee <chanholee@apache.org>
tbonelee
pushed a commit
that referenced
this pull request
Nov 3, 2025
### What is this PR for? #5111 (comment) #5108 After upgrading Playwright to the latest version(1.53.2 to 1.56.1), several test cases started failing on WebKit. The issue was resolved by rolling back to the previous minor version(1.55.1). [related issue] microsoft/playwright#37766 ### What type of PR is it? Hot Fix ### Todos ### What is the Jira issue? ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #5115 from dididy/fix/e2e. Signed-off-by: ChanHo Lee <chanholee@apache.org>
tbonelee
pushed a commit
that referenced
this pull request
Nov 3, 2025
### What is this PR for? #5111 (comment) #5108 After upgrading Playwright to the latest version(1.53.2 to 1.56.1), several test cases started failing on WebKit. The issue was resolved by rolling back to the previous minor version(1.55.1). [related issue] microsoft/playwright#37766 ### What type of PR is it? Hot Fix ### Todos ### What is the Jira issue? ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #5115 from dididy/fix/e2e. Signed-off-by: ChanHo Lee <chanholee@apache.org> (cherry picked from commit bf62a2a) Signed-off-by: ChanHo Lee <chanholee@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
#5107
https://github.com/apache/zeppelin/actions/runs/18662031473/job/53204596550?pr=5107
In the Playwright E2E tests of the above bump PR, the following issue occurred:
This issue seems to be caused by the Playwright browser installation step being version-locked in
zeppelin-web-angular/pom.xml's playwright-install execution.Instead of managing it in
pom.xml, it would be better to add it to thepostinstallscript inzeppelin-web-angular/package.json, so that Playwright browsers are automatically installed when runningnpm install, either in CI and on a local environment. This PR addresses that change.61ff629
Including the CI caching procedure as above, it seems optimized as previous approach(pom.xml).
What type of PR is it?
Improvement
Todos
What is the Jira issue?
ZEPPELIN-6370
How should this be tested?
Screenshots (if appropriate)
Questions: