[ZEPPELIN-6365] Add E2E tests about Notebook Repositories (/notebook-repos)#5105
[ZEPPELIN-6365] Add E2E tests about Notebook Repositories (/notebook-repos)#5105tbonelee merged 6 commits intoapache:masterfrom
Conversation
There was a problem hiding this comment.
https://github.com/apache/zeppelin/actions/runs/18502535395/job/52722968526?pr=5105
Currently, the user logging in during the auth test is not an admin, so access to the notebook-repos is restricted. Therefore, it seems necessary to modify this part as shown above commit.
Also, it seems you need to ensure that the page is ready before calling performLoginIfRequired. You can refer to above commit for that part. Thanks for contributing to the E2E tests!
https://github.com/kmularise/zeppelin/blob/ZEPPELIN-6365/conf/shiro.ini.template#L125
|
@dididy Thanks for the detailed review and the code examples in your branch! Your suggestions effectively address the test user permissions and page loading issues. I've studied your code changes and will apply them to my branch. |
|
https://github.com/apache/zeppelin/actions/runs/18749572769/job/53485262597?pr=5105 It seems that the above changes only added Please have a look at the following commit. |
|
It doesn't seem to be used, so it can probably be removed. |
…repos) ### What is this PR for? Addition of Notebook Repositories E2E tests for New UI --- PAGES.WORKSPACE.NOTEBOOK_REPOS → src/app/pages/workspace/notebook-repos/notebook-repos.component PAGES.WORKSPACE.NOTEBOOK_REPOS_ITEM → src/app/pages/workspace/notebook-repos/item/item.component ### What type of PR is it? Improvement ### Todos * [X] - add Notebook Repositories E2E test ### What is the Jira issue? [ZEPPELIN-6365](https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=632&view=detail&selectedIssue=ZEPPELIN-6365) ### How should this be tested? by E2E test CLI ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #5105 from kmularise/ZEPPELIN-6365. Signed-off-by: ChanHo Lee <chanholee@apache.org> (cherry picked from commit b279255) Signed-off-by: ChanHo Lee <chanholee@apache.org>
|
Thanks, merged into master and branch. |
What is this PR for?
Addition of Notebook Repositories E2E tests for New UI
PAGES.WORKSPACE.NOTEBOOK_REPOS
→ src/app/pages/workspace/notebook-repos/notebook-repos.component
PAGES.WORKSPACE.NOTEBOOK_REPOS_ITEM
→ src/app/pages/workspace/notebook-repos/item/item.component
What type of PR is it?
Improvement
Todos
What is the Jira issue?
ZEPPELIN-6365
How should this be tested?
by E2E test CLI
Screenshots (if appropriate)
Questions: