Skip to content

[ZEPPELIN-6365] Add E2E tests about Notebook Repositories (/notebook-repos)#5105

Merged
tbonelee merged 6 commits intoapache:masterfrom
kmularise:ZEPPELIN-6365
Oct 26, 2025
Merged

[ZEPPELIN-6365] Add E2E tests about Notebook Repositories (/notebook-repos)#5105
tbonelee merged 6 commits intoapache:masterfrom
kmularise:ZEPPELIN-6365

Conversation

@kmularise
Copy link
Copy Markdown
Contributor

What is this PR for?

Addition of Notebook Repositories E2E tests for New UI


PAGES.WORKSPACE.NOTEBOOK_REPOS

→ src/app/pages/workspace/notebook-repos/notebook-repos.component

PAGES.WORKSPACE.NOTEBOOK_REPOS_ITEM

→ src/app/pages/workspace/notebook-repos/item/item.component

What type of PR is it?

Improvement

Todos

  • - add Notebook Repositories E2E test

What is the Jira issue?

ZEPPELIN-6365

How should this be tested?

by E2E test CLI

Screenshots (if appropriate)

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@kmularise kmularise changed the title [ZEPPELIN-6365] [ZEPPELIN-6365] Notebook Repositories (/notebook-repos) Oct 14, 2025
@kmularise kmularise changed the title [ZEPPELIN-6365] Notebook Repositories (/notebook-repos) [ZEPPELIN-6365] Add E2E tests about Notebook Repositories (/notebook-repos) Oct 14, 2025
Copy link
Copy Markdown
Contributor

@dididy dididy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/apache/zeppelin/actions/runs/18502535395/job/52722968526?pr=5105

dididy@cfdc2dd

Currently, the user logging in during the auth test is not an admin, so access to the notebook-repos is restricted. Therefore, it seems necessary to modify this part as shown above commit.

dididy@19ff367

Also, it seems you need to ensure that the page is ready before calling performLoginIfRequired. You can refer to above commit for that part. Thanks for contributing to the E2E tests!


https://github.com/kmularise/zeppelin/blob/ZEPPELIN-6365/conf/shiro.ini.template#L125

@kmularise
Copy link
Copy Markdown
Contributor Author

@dididy Thanks for the detailed review and the code examples in your branch! Your suggestions effectively address the test user permissions and page loading issues.

I've studied your code changes and will apply them to my branch.

@dididy
Copy link
Copy Markdown
Contributor

dididy commented Oct 23, 2025

https://github.com/apache/zeppelin/actions/runs/18749572769/job/53485262597?pr=5105

5971435

It seems that the above changes only added waitForZeppelinReady-related code to notebook-repo-item-display.spec.ts. The same should probably be added to the other four notebook-repo-item-* tests as well as notebook-repos-page-structure.spec.ts. In fact, in the above test, the parts where waitForZeppelinReady was added passed successfully, but the parts where it wasn’t added failed.


Please have a look at the following commit.

dididy@19ff367

@dididy
Copy link
Copy Markdown
Contributor

dididy commented Oct 23, 2025

e2e/models/published-paragraph-page.ts:
isPublishedParagraphVisible, getErrorModalTitle, isDynamicFormsVisible, isResultVisible

e2e/models/published-paragraph-page.util.ts:
testConfirmationModalForNoResultParagraph

It doesn't seem to be used, so it can probably be removed.

Copy link
Copy Markdown
Contributor

@dididy dididy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like all the e2e tests are passing. Thanks!

@tbonelee tbonelee merged commit b279255 into apache:master Oct 26, 2025
18 of 19 checks passed
tbonelee pushed a commit that referenced this pull request Oct 26, 2025
…repos)

### What is this PR for?
Addition of Notebook Repositories E2E tests for New UI

---

PAGES.WORKSPACE.NOTEBOOK_REPOS

→ src/app/pages/workspace/notebook-repos/notebook-repos.component

PAGES.WORKSPACE.NOTEBOOK_REPOS_ITEM

→ src/app/pages/workspace/notebook-repos/item/item.component

### What type of PR is it?
Improvement

### Todos
* [X] - add Notebook Repositories E2E test

### What is the Jira issue?
[ZEPPELIN-6365](https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=632&view=detail&selectedIssue=ZEPPELIN-6365)

### How should this be tested?
by E2E test CLI

### Screenshots (if appropriate)

### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Closes #5105 from kmularise/ZEPPELIN-6365.

Signed-off-by: ChanHo Lee <chanholee@apache.org>
(cherry picked from commit b279255)
Signed-off-by: ChanHo Lee <chanholee@apache.org>
@tbonelee
Copy link
Copy Markdown
Contributor

Thanks, merged into master and branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants