[ZEPPELIN-6358] Add E2E tests about /#/notebook/:noteid for New UI#5101
Open
dididy wants to merge 134 commits intoapache:masterfrom
Open
[ZEPPELIN-6358] Add E2E tests about /#/notebook/:noteid for New UI#5101dididy wants to merge 134 commits intoapache:masterfrom
dididy wants to merge 134 commits intoapache:masterfrom
Conversation
d6228ac to
b07b933
Compare
5 tasks
Contributor
|
Could you rebase this onto master branch? |
tbonelee
requested changes
Oct 26, 2025
Contributor
tbonelee
left a comment
There was a problem hiding this comment.
Could you take a quick pass on two areas?
- There are places where try/catch accepts both error and non-error paths. Could we make these more explicit, either intentionally silencing with a clear rationale or failing, so we reduce false positives?
- For browser-specific branches (e.g., notebook-keyboard-page.ts → executePlatformShortcut), could we extract that logic so the main flow reads sequentially and the differences are isolated?
d058c16 to
9bd2f40
Compare
Contributor
Author
1dc6ffa to
f4f51b1
Compare
Contributor
Author
|
It took some time to incorporate the review feedback, do incremental refactoring, and clean up the tests that were failing in CI.
Once all of those PRs are merged, we can close the current PR accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Addition and improvement of notebook-related E2E tests for New UI
/#/notebook/:noteId – View or edit a specific notebook
/#/notebook/:noteId/revision/:revisionId – View a specific revision of a notebook
/#/notebook/:noteId/paragraph/:paragraphId – Notebook paragraph presentation mode
PAGES.WORKSPACE.NOTEBOOK
→ src/app/pages/workspace/notebook/notebook.component
PAGES.WORKSPACE.NOTEBOOK_ACTION_BAR
→ src/app/pages/workspace/notebook/action-bar/action-bar.component
PAGES.WORKSPACE.NOTEBOOK_PARAGRAPH
→ src/app/pages/workspace/notebook/paragraph/paragraph.component
PAGES.WORKSPACE.NOTEBOOK_SIDEBAR
→ src/app/pages/workspace/notebook/sidebar/sidebar.component
PAGES.WORKSPACE.PUBLISHED_PARAGRAPH
→ src/app/pages/workspace/published/paragraph/paragraph.component
What type of PR is it?
Improvement
Todos
What is the Jira issue?
ZEPPELIN-6358
How should this be tested?
Screenshots (if appropriate)
Questions: