Improve test coverage for Catalina valves#980
Open
onkar717 wants to merge 1 commit intoapache:mainfrom
Open
Conversation
Add tests for RemoteCIDRValve and LoadBalancerDrainingValve. Extend tests for ErrorReportValve, RemoteIpValve, SSLValve, and StuckThreadDetectionValve to cover edge cases and properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves test coverage for by adding tests for
currently uncovered execution paths related to configuration,
validation and request processing.
Motivation
During a review of Valve test coverage, several code paths were found
to have limited or no direct unit tests. Adding targeted tests helps
improve reliability and reduces the risk of regressions during future
changes.
Changes
Added new tests covering
Testing
All tests pass locally:
Coverage Impact
This PR improves instruction coverage for by exercising
previously untested execution paths.
Some error handling branches (for example OS-level failures or rare
edge conditions) are difficult to reliably reproduce in unit tests,
but all realistically testable logic paths are covered.
Impact
No functional changes.
Test coverage improvement only.
Notes
This PR is part of ongoing work to systematically improve test
coverage for Tomcat Valve implementations.
Checklist