[TIKA-4704] Implement tearDown method to remove temp directories by THausherr · Pull Request #2735 · apache/tika

THausherr · 2026-04-05T17:10:23Z

Add tearDown method to clean up temporary directory after tests.

Thanks for your contribution to Apache Tika! Your help is appreciated!

Before opening the pull request, please verify that

there is an open issue on the Tika issue tracker which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
the issue ID (TIKA-XXXX)
- is referenced in the title of the pull request
- and placed in front of your commit messages surrounded by square brackets ([TIKA-XXXX] Issue or pull request title)
commits are squashed into a single one (or few commits for larger changes)
Tika is successfully built and unit tests pass by running ./mvnw clean test
there should be no conflicts when merging the pull request branch into the recent main branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled main branch
if you add new module that downstream users will depend upon add it to relevant group in tika-bom/pom.xml.

We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!

Add tearDown method to clean up temporary directory after tests.

Copilot

Pull request overview

This PR aims to prevent test pollution by cleaning up the temporary unpack-emitter directory created by UnpackerResourceTest after the test suite finishes.

Changes:

Added a JUnit @AfterAll teardown method to delete the temp directory used by unpack emitter tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...tika-server-standard/src/test/java/org/apache/tika/server/standard/UnpackerResourceTest.java

…/server/standard/UnpackerResourceTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...r-standard/src/test/java/org/apache/tika/server/standard/UnpackerResourceWithConfigTest.java

...tika-server-standard/src/test/java/org/apache/tika/server/standard/UnpackerResourceTest.java

...r-standard/src/test/java/org/apache/tika/server/standard/UnpackerResourceWithConfigTest.java

…/server/standard/UnpackerResourceWithConfigTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…/server/standard/UnpackerResourceTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…/server/standard/UnpackerResourceWithConfigTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...r-standard/src/test/java/org/apache/tika/server/standard/UnpackerResourceWithConfigTest.java

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...r-standard/src/test/java/org/apache/tika/server/standard/UnpackerResourceWithConfigTest.java

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...tika-server-standard/src/test/java/org/apache/tika/server/standard/UnpackerResourceTest.java

...r-standard/src/test/java/org/apache/tika/server/standard/UnpackerResourceWithConfigTest.java

…/server/standard/UnpackerResourceTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...r-standard/src/test/java/org/apache/tika/server/standard/UnpackerResourceWithConfigTest.java

[TIKA-4704] Implement tearDown method in UnpackerResourceTest

8e30c88

Add tearDown method to clean up temporary directory after tests.

Copilot AI review requested due to automatic review settings April 5, 2026 17:10

Copilot started reviewing on behalf of THausherr April 5, 2026 17:11 View session

Implement tearDown method in UnpackerResourceWithConfigTest

8291565

Add tearDown method to clean up temporary directory after tests.

THausherr changed the title ~~[TIKA-4704] Implement tearDown method in UnpackerResourceTest~~ [TIKA-4704] Implement tearDown method to remove temp directories Apr 5, 2026

Copilot AI reviewed Apr 5, 2026

View reviewed changes

...tika-server-standard/src/test/java/org/apache/tika/server/standard/UnpackerResourceTest.java Outdated Show resolved Hide resolved

...tika-server-standard/src/test/java/org/apache/tika/server/standard/UnpackerResourceTest.java Outdated Show resolved Hide resolved

THausherr and others added 3 commits April 5, 2026 19:43

Update tika-server/tika-server-standard/src/test/java/org/apache/tika…

9ced7fe

…/server/standard/UnpackerResourceTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Replace Files.delete with FileUtils.deleteDirectory

d8ce867

Use FileUtils to delete unpackTempDir in tearDown

3f6e7ad

THausherr requested a review from Copilot April 5, 2026 17:47

Copilot started reviewing on behalf of THausherr April 5, 2026 17:47 View session

Copilot AI reviewed Apr 5, 2026

View reviewed changes

THausherr and others added 3 commits April 5, 2026 19:50

Update tika-server/tika-server-standard/src/test/java/org/apache/tika…

a212eda

…/server/standard/UnpackerResourceWithConfigTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update tika-server/tika-server-standard/src/test/java/org/apache/tika…

3075699

…/server/standard/UnpackerResourceTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update tika-server/tika-server-standard/src/test/java/org/apache/tika…

847c044

…/server/standard/UnpackerResourceWithConfigTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

THausherr requested a review from Copilot April 5, 2026 17:53

Copilot started reviewing on behalf of THausherr April 5, 2026 17:54 View session

Copilot AI reviewed Apr 5, 2026

View reviewed changes

...r-standard/src/test/java/org/apache/tika/server/standard/UnpackerResourceWithConfigTest.java Outdated Show resolved Hide resolved

Change method to delete unpackTempDir directory

f5022bb

THausherr requested a review from Copilot April 5, 2026 18:01

Copilot started reviewing on behalf of THausherr April 5, 2026 18:01 View session

Copilot AI reviewed Apr 5, 2026

View reviewed changes

...r-standard/src/test/java/org/apache/tika/server/standard/UnpackerResourceWithConfigTest.java Show resolved Hide resolved

Override tearDown method in UnpackerResourceWithConfigTest

3ae10bc

THausherr requested a review from Copilot April 5, 2026 18:07

Copilot started reviewing on behalf of THausherr April 5, 2026 18:07 View session

Copilot AI reviewed Apr 5, 2026

View reviewed changes

Update tika-server/tika-server-standard/src/test/java/org/apache/tika…

baacab7

…/server/standard/UnpackerResourceTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

THausherr requested a review from Copilot April 5, 2026 18:27

Copilot started reviewing on behalf of THausherr April 5, 2026 18:28 View session

Copilot AI reviewed Apr 5, 2026

View reviewed changes

...r-standard/src/test/java/org/apache/tika/server/standard/UnpackerResourceWithConfigTest.java Show resolved Hide resolved

THausherr merged commit 2570a08 into main Apr 5, 2026
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TIKA-4704] Implement tearDown method to remove temp directories#2735

[TIKA-4704] Implement tearDown method to remove temp directories#2735
THausherr merged 11 commits intomainfrom
TIKA-4704-10

THausherr commented Apr 5, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

THausherr commented Apr 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants