feat(frontend): Virtual Environments: Show loading spinner while system packages resolve#5644
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5644 +/- ##
============================================
+ Coverage 54.60% 54.64% +0.04%
Complexity 2927 2927
============================================
Files 1109 1109
Lines 42828 42840 +12
Branches 4608 4608
============================================
+ Hits 23385 23409 +24
+ Misses 18081 18063 -18
- Partials 1362 1368 +6
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Seems like this PR is depends on #5613 so I'll review this PR after it's merged. |
Contributor
Author
kunwp1
approved these changes
Jun 16, 2026
kunwp1
left a comment
kunwp1
left a comment
Contributor
There was a problem hiding this comment.
LGTM! A few minor comments.
Contributor
Automated Reviewer SuggestionsBased on the
|
Contributor
|
Forgot to mention this: can you add more test cases? |
Contributor
|
Also can you create an issue corresponding to this PR? |
Contributor
Author
|
@kunwp1 I have addressed both of your comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
PR #5613 removed the
system-requirements-lock.txtfile which changes how system packages are loaded. Previously, the package list was available immediately from the lock file. With the new approach, the system package set is generated on demand by creating a temporary environment, installing the requirements, and running pip freeze, which introduces a noticeable delay on the initial load.The PR introduces new UI changes to handle this new loading state and provide feedback to the user while the system packages are being resolved by adding a loading spinner.
Any related issues, documentation, discussions?
Related PR: #5613. Closes #5926
How was this PR tested?
Tested manually.
Was this PR authored or co-authored using generative AI tooling?
Co-authored using: Claude Code