[SYSTEMDS-3953] Support value averaging for quantile operations on even-length arrays#2565
Closed
ywcb00 wants to merge 6 commits into
Closed
[SYSTEMDS-3953] Support value averaging for quantile operations on even-length arrays#2565ywcb00 wants to merge 6 commits into
ywcb00 wants to merge 6 commits into
Conversation
…when picking multiple values for quantile computation feat(test/functions/binary/matrix/QuantileTest.java): test the quantile function with an array as percentiles argument
…rtile test cases since they still fail due to the second issue reported in SYSTEMDS-3953
chore(test/functions/binary/matrix/QuantileTest.java): minor formatting
…: ignore the test case calling the quantile function with an array of percentiles and refer to SystemDS-3953
…st.java): ignore the test case calling the quantile function with an array of percentiles and refer to SystemDS-3953" This reverts commit 1d38b9d.
…eter again due to several failing test cases add a comment pointing to the jira issue SystemDS-3953 instead (test cases failing due to the second problem reported in this issue)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2565 +/- ##
============================================
- Coverage 71.60% 71.55% -0.05%
- Complexity 50168 50255 +87
============================================
Files 1618 1623 +5
Lines 194054 194317 +263
Branches 37939 37965 +26
============================================
+ Hits 138947 139049 +102
- Misses 44183 44359 +176
+ Partials 10924 10909 -15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the second issue reported in SYSTEMDS-3953 by passing the boolean argument to the underlying method. This is only a minor change to the main code.
The PR also adds respective test cases, which are ignored for now since they are failing due to the second issue in SYSTEMDS-3953.