Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-1372. Fix tensorflow 2.6.5 in CI always failed#1057

Closed
cdmikechen wants to merge 5 commits intoapache:masterfrom
shangyuantech:SUBMARINE-1372
Closed

SUBMARINE-1372. Fix tensorflow 2.6.5 in CI always failed#1057
cdmikechen wants to merge 5 commits intoapache:masterfrom
shangyuantech:SUBMARINE-1372

Conversation

@cdmikechen
Copy link
Copy Markdown
Contributor

@cdmikechen cdmikechen commented Mar 19, 2023

What is this PR for?

Limit torch under 3.0.0 and fix mypy error

What type of PR is it?

Hot Fix

Todos

  • - Limit typeguard < 3.0.0
  • - Fix mypy SQLAlchemy type check
  • - Add pipdeptree to better trace python dependency issues

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-1372

How should this be tested?

python CI

Screenshots (if appropriate)

Questions:

  • Do the license files need updating? No
  • Are there breaking changes for older versions? No
  • Does this need new documentation? No

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2023

Codecov Report

Merging #1057 (9dc3c1f) into master (de303fa) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1057      +/-   ##
==========================================
+ Coverage   75.94%   75.98%   +0.04%     
==========================================
  Files         119      119              
  Lines        5000     5000              
==========================================
+ Hits         3797     3799       +2     
+ Misses       1203     1201       -2     
Flag Coverage Δ
python-integration 59.72% <100.00%> (+2.12%) ⬆️
python-unit 52.48% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...submarine/store/model_registry/sqlalchemy_store.py 97.09% <100.00%> (+0.82%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cdmikechen cdmikechen requested a review from pingsutw March 20, 2023 00:07
@cdmikechen cdmikechen added the python Pull requests that update Python code label Mar 20, 2023
@asfgit asfgit closed this in 5987b92 Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants