Repository navigation
GH workflow validate-changelog: Make the /no-changelog command actually clear the failed changelog check - #5099
Merged
Conversation
github-actions
Bot
added
the
documentation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
In-flight or previously labeled PRs can still retain stale checks, and oversized PRs may be evaluated incompletely.
3 open findings
What changed in this PR
Makes /no-changelog explicitly rerun changelog validation while reducing exposure to PR-authored code.
Changes:
- Adds explicit validation reruns after label changes.
- Uses GitHub APIs and the base-branch validator.
- Updates changelog documentation.
| File | Description |
|---|---|
.github/workflows/changelog-comment-command.yml |
Applies labels and reruns validation. |
.github/workflows/validate-changelog.yml |
Validates PR files through APIs. |
dev-docs/changelog.adoc |
Clarifies validation behavior. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous version of
changelog-comment-command.ymldid not do what it claimed. It works fine if a committer sets theno-changeloglabel, then the failed changelog validation job re-runs and turns green.But the new
/no-changelogcomment path worked only half-way. The workflow set the label correctly, but we assumed that would then trigger thevalidate-changelogagain, but it does not since it was not a human action, as a recursion break.This re-write explicitly calls the
validate-changelogworkflow after the label is set bychangelog-comment-command.yml.🤖 Implemented by Claude. Checked by me.