Repository navigation
XML Lexer: Support ENTITY, NOTION, Enumerations with NMTokens for DTD editor - #9700
Open
matthiasblaesing wants to merge 3 commits into
Open
matthiasblaesing wants to merge 3 commits into
matthiasblaesing wants to merge 3 commits into
Conversation
It was noticed that NetBeans is not able to properly display its own apichanges-1.1.dtd document. Analysis showed, that the hand written lexer did not even cover the cases for ENTITY and NOTION declarations: <!NOTATION simple PUBLIC "Public Simple"> <!ENTITY ProjectLogo PUBLIC "DEMO // PUBLIC" "https://netbeans.apache.org/_/images/apache-netbeans.svg"> <!ENTITY % ProjectName 'Apache NetBeans' > What is more the DTD contains enumerations containing literals with numbers. These were rejected by the lexer.
matthiasblaesing
added
Code cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was noticed that NetBeans is not able to properly display its own apichanges-1.1.dtd document:
Analysis showed, that the hand written lexer did not even cover the cases for ENTITY and NOTION declarations:
What is more the DTD contains enumerations containing literals with numbers. These were rejected by the lexer.
After adding the missing cases the document renders correctly: