Repository navigation
fix(cli): emit one JSON object per ref in list-refs - #4169
Merged
Merged
Conversation
The nested comprehension emitted one object per retention property, so a single snapshot ref produced several JSON objects. Build one object per ref and merge its properties into it.
Fokko
approved these changes
Oct 28, 2026
Fokko
left a comment
Fokko
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for fixing this @aayusbhat26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4098.
The JSON output for
list-refsbuilt one object per retention property, so a single snapshot ref produced multiple objects. Build one object per ref and merge its properties into it.Tests: added a regression test in
tests/cli/test_output.py.pytest tests/clipasses (102 tests);ruff checkandruff format --checkpass.