HIVE-29481: Fix create table with transactional=false and transactional_properties=insert_only to create a translated to external table#6432
Merged
Conversation
VenuReddy2103
changed the title
…al_properties=insert_only to create a translated to external table
VenuReddy2103
force-pushed
the
HIVE-29481
branch
from
2a79f0a to
9097545
Compare
|
| table_params.append("key1=val1"); | ||
| table_params.append(";"); | ||
| table_params.append("transactional_properties=insert_only"); | ||
| table_params.append("transactional=true;transactional_properties=insert_only"); |
Contributor
There was a problem hiding this comment.
When the table type is managed, do we still need to mention transaction='true' in the table props?
Contributor
There was a problem hiding this comment.
I see, compiler will add this if it is missing. So it makes sense to add transactional property, if we are directly calling metastore client.
dengzhhu653
approved these changes
Apr 15, 2026
VenuReddy2103
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
insert_onlyis meaningful only whentransactionalistrue. Have modified to create a translated to external table when create table has'transactional'='false','transactional_properties'='insert_only'table properties, making it consistent with following cases:'transactional'='false','transactional_properties'='default''transactional'='false'Why are the changes needed?
When a table is created with
'transactional'='false','transactional_properties'='insert_only'table properties and data is inserted to it, data queries fail.Does this PR introduce any user-facing change?
No
How was this patch tested?
Added new tests