Skip to content

[FLINK-12461] Document Scala 2.12.x situation - #14780

Closed
aljoscha wants to merge 2 commits into
apache:masterfrom
aljoscha:flink-12461-document-custom-scala-build
Closed

[FLINK-12461] Document Scala 2.12.x situation#14780
aljoscha wants to merge 2 commits into
apache:masterfrom
aljoscha:flink-12461-document-custom-scala-build

Conversation

@aljoscha

Copy link
Copy Markdown
Contributor

What is the purpose of the change

Scala versions after 2.12.8 are not binary compatible with previous versions, we link to the relevant release notes and point users towards building their own release using a more recent version.

It's a pure documentation change, no testing needed.

@aljoscha
aljoscha requested a review from sjwiesman January 27, 2021 14:21
@flinkbot

Copy link
Copy Markdown
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 8251a89 (Wed Jan 27 14:24:16 UTC 2021)

Warnings:

  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot

flinkbot commented Jan 27, 2021

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Comment thread docs/flinkDev/building.md
Comment thread docs/dev/project-configuration.md Outdated

@sjwiesman sjwiesman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time, I made a suggestion to be a little more clear with our language but the basic content makes sense. Also +1 to Chesnay's comment. Feel free to address when merging :)

Co-authored-by: Seth Wiesman <sjwiesman@gmail.com>
@aljoscha

Copy link
Copy Markdown
Contributor Author

Thanks for the reviews!

@aljoscha

Copy link
Copy Markdown
Contributor Author

merged

@aljoscha aljoscha closed this Jan 28, 2021
@aljoscha
aljoscha deleted the flink-12461-document-custom-scala-build branch January 28, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants