docs: add Alibaba attribution to legacy-derived files in fesod-sheet#898
Open
skytin1004 wants to merge 3 commits intoapache:mainfrom
Open
docs: add Alibaba attribution to legacy-derived files in fesod-sheet#898skytin1004 wants to merge 3 commits intoapache:mainfrom
skytin1004 wants to merge 3 commits intoapache:mainfrom
Conversation
delei
reviewed
Apr 17, 2026
Member
There was a problem hiding this comment.
Hi, @skytin1004
FYI, FastExcel, FastExcelFactory, and FesodSheet are not derived from Alibaba's EasyExcel.
Author
|
Thanks @delei for the clarification. I've removed the attribution blocks from For the remaining three files, I kept the attribution based on their copy history from existing files that already retain Alibaba attribution:
If these should also be treated as FastExcel/Fesod-added files, I'm happy to update them accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Related: #878
This PR adds the Alibaba attribution block to 6
fesod-sheetfiles that appear to be legacy EasyExcel-derived or legacy-derived files.What's changed?
I reviewed the Java files in
fesod-sheetand checked the remainingASF-onlyfiles against git history, prior refactor commits, and existing files that already keep Alibaba attribution.I scanned attribution across the module
fesod-sheetBased on that review, I identified 6 files with clear evidence of derivation from legacy EasyExcel code or legacy-derived test data, and added the required Alibaba attribution block after the ASF license header:
FesodSheet.javaFastExcel.javaFastExcelFactory.javaMaxHeadSizeData.javaHiddenSheetsData.javaWriteSheetData.javaI selected these files conservatively based on the following evidence:
FesodSheet.javatraces back to the legacy core API (EasyExcel.java/EasyExcelFactory.java) viagit log --followFastExcel.javais part of the EasyExcel-to-FastExcel compatibility/rename path and retained as a deprecated aliasFastExcelFactory.javafollows the same legacy factory path and is kept as a deprecated compatibility aliasMaxHeadSizeData.javawas copied fromComplexHeadData.java, which already retains Alibaba attributionHiddenSheetsData.javawas copied fromMultipleSheetsData.java, which already retains Alibaba attributionWriteSheetData.javawas copied fromNoHeadData.java, which already retains Alibaba attributionI intentionally kept this PR narrow and did not update the other remaining
ASF-onlyfiles infesod-sheet, because their introduction commits indicate they are FastExcel/Fesod-added feature, bugfix, fuzz, or unit-test files.Checklist