Skip to content

docs: add Alibaba attribution to legacy-derived files in fesod-sheet#898

Open
skytin1004 wants to merge 3 commits intoapache:mainfrom
skytin1004:fix/878-add-alibaba-attribution-sheet
Open

docs: add Alibaba attribution to legacy-derived files in fesod-sheet#898
skytin1004 wants to merge 3 commits intoapache:mainfrom
skytin1004:fix/878-add-alibaba-attribution-sheet

Conversation

@skytin1004
Copy link
Copy Markdown

Purpose of the pull request

Related: #878

This PR adds the Alibaba attribution block to 6 fesod-sheet files that appear to be legacy EasyExcel-derived or legacy-derived files.

What's changed?

I reviewed the Java files in fesod-sheet and checked the remaining ASF-only files against git history, prior refactor commits, and existing files that already keep Alibaba attribution.

I scanned attribution across the module

  • 469 Java files in fesod-sheet
  • 412 files already had ASF + Alibaba headers
  • 57 files had ASF-only headers
  • 0 files were missing ASF headers

Based on that review, I identified 6 files with clear evidence of derivation from legacy EasyExcel code or legacy-derived test data, and added the required Alibaba attribution block after the ASF license header:

  • FesodSheet.java
  • FastExcel.java
  • FastExcelFactory.java
  • MaxHeadSizeData.java
  • HiddenSheetsData.java
  • WriteSheetData.java

I selected these files conservatively based on the following evidence:

  • FesodSheet.java traces back to the legacy core API (EasyExcel.java / EasyExcelFactory.java) via git log --follow
  • FastExcel.java is part of the EasyExcel-to-FastExcel compatibility/rename path and retained as a deprecated alias
  • FastExcelFactory.java follows the same legacy factory path and is kept as a deprecated compatibility alias
  • MaxHeadSizeData.java was copied from ComplexHeadData.java, which already retains Alibaba attribution
  • HiddenSheetsData.java was copied from MultipleSheetsData.java, which already retains Alibaba attribution
  • WriteSheetData.java was copied from NoHeadData.java, which already retains Alibaba attribution

I intentionally kept this PR narrow and did not update the other remaining ASF-only files in fesod-sheet, because their introduction commits indicate they are FastExcel/Fesod-added feature, bugfix, fuzz, or unit-test files.

Checklist

  • I have read the Contributor Guide.
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Copy link
Copy Markdown
Member

@delei delei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @skytin1004

FYI, FastExcel, FastExcelFactory, and FesodSheet are not derived from Alibaba's EasyExcel.

@skytin1004
Copy link
Copy Markdown
Author

skytin1004 commented Apr 17, 2026

Thanks @delei for the clarification.

I've removed the attribution blocks from FastExcel.java, FastExcelFactory.java, and FesodSheet.java.

For the remaining three files, I kept the attribution based on their copy history from existing files that already retain Alibaba attribution:

  • MaxHeadSizeData.java: copied from ComplexHeadData.java in 8ad28c2
  • HiddenSheetsData.java: copied from MultipleSheetsData.java in 1088d68
  • WriteSheetData.java: copied from NoHeadData.java in 07582a0

If these should also be treated as FastExcel/Fesod-added files, I'm happy to update them accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants