Skip to content

docs: add Alibaba attribution to 5 legacy-derived files in fesod-examples#897

Merged
delei merged 1 commit intoapache:mainfrom
skytin1004:fix/878-add-alibaba-attribution-examples
Apr 17, 2026
Merged

docs: add Alibaba attribution to 5 legacy-derived files in fesod-examples#897
delei merged 1 commit intoapache:mainfrom
skytin1004:fix/878-add-alibaba-attribution-examples

Conversation

@skytin1004
Copy link
Copy Markdown
Contributor

Purpose of the pull request

Related: #878

This PR adds the Alibaba attribution block to 5 fesod-sheet-examples files that were verified as legacy EasyExcel-derived examples.

What's changed?

I reviewed the Java files in fesod-examples and checked the remaining ASF-only files against the pre-refactor example/test sources.

Based on that review, I identified 5 files with clear evidence of derivation from legacy EasyExcel examples and added the required Alibaba attribution block after the ASF license header:

  • BasicWriteExample.java
  • StyleWriteExample.java
  • BasicReadExample.java
  • ConverterReadExample.java
  • IndexOrNameReadExample.java

These 5 files were selected conservatively based on direct evidence of derivation:

  • all 5 files were introduced by c09387f (refactor(examples): Fesod Examples Module Refactoring (#770))
  • BasicWriteExample.java maps to WriteTest.simpleWrite() in the pre-refactor tree
  • StyleWriteExample.java maps to WriteTest.annotationStyleWrite() in the pre-refactor tree
  • BasicReadExample.java maps to ReadTest.simpleRead() in the pre-refactor tree
  • ConverterReadExample.java maps to ReadTest.converterRead() in the pre-refactor tree
  • IndexOrNameReadExample.java maps to ReadTest.indexOrNameRead() in the pre-refactor tree

I intentionally kept this PR narrow and only updated files whose legacy origin could be verified with confidence.

Checklist

  • I have read the Contributor Guide.
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@skytin1004
Copy link
Copy Markdown
Contributor Author

@psxjoy I narrowed this PR to 5 fesod-sheet-examples files whose legacy EasyExcel origin could be verified with confidence.

When you have a moment, could you please take a look?

Copy link
Copy Markdown
Member

@delei delei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delei delei added the PR: first-time contributor first-time contributor label Apr 16, 2026
@delei delei merged commit 14704d6 into apache:main Apr 17, 2026
9 checks passed
@skytin1004 skytin1004 deleted the fix/878-add-alibaba-attribution-examples branch April 17, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: first-time contributor first-time contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants