Repository navigation
Conversation
…che#70196) Two VARIANT regression cases can fail despite correct results: - The schema-change double-write case compares JSON booleans against numeric values in its expected output. The input contains booleans, which are preserved before and after schema change. Regenerate the expected output and add a tie breaker to the limited query. - The SNII range case checks a cumulative filtered-row counter during each segment's initialization. When a segment that filters no rows runs first, it fails before the segment containing the filtered row is processed. Check the completed query profile instead, and write the test data in separate rowsets to cover this ordering. None - Test: ASAN BE and FE build; `double_write_schema_change_with_variant` regression (generated expected output and ordinary comparison); `regression_test_variant_var_index_snii` regression (five consecutive runs). The original schema-change mismatch and a multi-rowset counter failure were reproduced before the fixes. - Behavior changed: No product behavior change. - Does this need documentation: No. (cherry picked from commit 6969d59)
Member
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run cloud_p0 |
1 similar comment
Member
Author
|
run cloud_p0 |
…e .out Cherry-pick of apache#70196 brought master's expected JSON (public:true, author-first commit keys). branch-4.x still serializes public as 1/0 and sha-first commit object keys, so NonConcurrent test_double_write_when_schema_change failed qt_two_phase_off/on. Keep the groovy order-by stabilization; rewrite .out to 4.x format.
Member
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #70196
Conflicts resolved in var_index_snii.groovy (took parse_to_variant multi-rowset inserts from the pick).