branch-4.1: [refactor](fe) Refine volatile expression handling #63403#65255
Open
yujun777 wants to merge 2 commits into
Open
branch-4.1: [refactor](fe) Refine volatile expression handling #63403#65255yujun777 wants to merge 2 commits into
yujun777 wants to merge 2 commits into
Conversation
Related PR: apache#62698 Problem Summary: PR apache#62698 introduced the UDF volatility property and added `VolatileExpression` / `VolatileIdentity` so volatile UDF calls can carry per-call identity and avoid unsafe optimizer rewrites. This PR is a follow-up refactoring for that change. It removes duplicated unique identity state from `UniqueFunction`, keeps `VolatileIdentity` as the single identity holder, moves volatile-expression helper methods into `ExpressionTrait`, and expands the former `AddProjectForUniqueFunction` rewrite to operate on volatile expressions rather than only unique functions.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick: #63403