[fix](nereids) make DUMP a non-reserved keyword#65254
Open
Baymine wants to merge 1 commit into
Open
Conversation
### What problem does this PR solve? Issue Number: close apache#65252 Problem Summary: DUMP is a lexer keyword (used by PLAN REPLAYER DUMP) but was missing from the nonReserved list in DorisParser.g4, so `dump` could not be used as a regular identifier (column, alias, table alias, CTE name, function argument, qualified reference). This restores backward compatibility with older versions (e.g. 2.1) where `dump` was usable as an identifier. Adding DUMP to nonReserved keeps it usable both as the PLAN REPLAYER DUMP keyword and as an identifier. ### Release note None ### Check List (For Author) - Test - [x] Unit Test: added NereidsParserTest#testParseDumpAsIdentifier - Behavior changed: - [x] No. - Does this need documentation? - [x] No.
Baymine
requested review from
924060929,
englefly,
morrySnow and
starocean999
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #65252
Problem Summary:
DUMPis a lexer keyword (used byPLAN REPLAYER DUMP) but was missing from thenonReservedlist inDorisParser.g4, sodumpcould not be used as a regular identifier (column, alias, table alias, CTE name, function argument, qualified reference). This restores backward compatibility with older versions (e.g. 2.1) wheredumpwas usable as an identifier. AddingDUMPtononReservedkeeps it usable both as thePLAN REPLAYER DUMPkeyword and as an identifier.Release note
None
Check List (For Author)
NereidsParserTest#testParseDumpAsIdentifiercoveringdumpas column alias, column ref, table alias, WHERE clause, qualified ref, function arg, CTE name, subquery alias, and confirmingPLAN REPLAYER DUMPstill parses.