Skip to content

[test](case) add some log in test case#65236

Merged
zhangstar333 merged 1 commit into
apache:masterfrom
zhangstar333:test_case_overwrite
Jul 6, 2026
Merged

[test](case) add some log in test case#65236
zhangstar333 merged 1 commit into
apache:masterfrom
zhangstar333:test_case_overwrite

Conversation

@zhangstar333

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333

Copy link
Copy Markdown
Contributor Author

/review

@zhangstar333

Copy link
Copy Markdown
Contributor Author

run buildall

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review completed. I found no substantiated blocking issue and no inline comments to submit.

Critical checkpoint conclusions:

  • Goal and scope: this PR modifies only regression-test/suites/external_table_p2/refactor_catalog_param/hive_on_hms_and_dlf.groovy, adding diagnostics and deterministic ordering around the existing Hive insert-overwrite regression. The code accomplishes the test-stabilization/logging goal.
  • Change size/focus: scoped to one regression suite. The new refresh catalog is broader than the old table-only refresh, but the previous test already performed manual refresh before validation, and FE Hive insert commit/table refresh paths already invalidate the relevant table metadata.
  • Concurrency/lifecycle/persistence/protocol/config: no product concurrency, lifecycle, persisted format, FE-BE protocol, or config change is introduced.
  • Parallel paths: compared adjacent external-table Hive/Glue insert-overwrite test patterns and FE refresh-table/catalog behavior; no missing parallel product path update is required for this test-only change.
  • Test coverage and expected results: no .out file is involved. The changed first row query now uses ORDER BY id, and the debug helper logs only on mismatch before the original assertions still fail.
  • Observability/performance: diagnostic logging is only on failure paths in a p2 external regression suite. No runtime product observability or hot-path performance concern found.

Subagent conclusions:

  • optimizer-rewrite: no candidates; the patch does not touch optimizer rules, rewrite semantics, joins, or aggregate planning.
  • tests-session-config: no candidates; no regression expected-output, session/config propagation, compatibility, or basic CI/style issue was substantiated.
  • Final convergence round 1 ended with both live subagents replying NO_NEW_VALUABLE_FINDINGS for the same ledger and empty proposed inline comment set.

User focus response: no additional user-provided review focus was present.

Validation limits: this runner is a shallow checkout and lacks thirdparty/installed, so I did not run the external p2 regression. Review was static, using the GitHub PR patch/API metadata and local surrounding code.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions Bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@zhangstar333 zhangstar333 merged commit e1c0e31 into apache:master Jul 6, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants