[test](case) add some log in test case#65236
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
/review |
|
run buildall |
There was a problem hiding this comment.
Automated review completed. I found no substantiated blocking issue and no inline comments to submit.
Critical checkpoint conclusions:
- Goal and scope: this PR modifies only
regression-test/suites/external_table_p2/refactor_catalog_param/hive_on_hms_and_dlf.groovy, adding diagnostics and deterministic ordering around the existing Hive insert-overwrite regression. The code accomplishes the test-stabilization/logging goal. - Change size/focus: scoped to one regression suite. The new
refresh catalogis broader than the old table-only refresh, but the previous test already performed manual refresh before validation, and FE Hive insert commit/table refresh paths already invalidate the relevant table metadata. - Concurrency/lifecycle/persistence/protocol/config: no product concurrency, lifecycle, persisted format, FE-BE protocol, or config change is introduced.
- Parallel paths: compared adjacent external-table Hive/Glue insert-overwrite test patterns and FE refresh-table/catalog behavior; no missing parallel product path update is required for this test-only change.
- Test coverage and expected results: no
.outfile is involved. The changed first row query now usesORDER BY id, and the debug helper logs only on mismatch before the original assertions still fail. - Observability/performance: diagnostic logging is only on failure paths in a p2 external regression suite. No runtime product observability or hot-path performance concern found.
Subagent conclusions:
optimizer-rewrite: no candidates; the patch does not touch optimizer rules, rewrite semantics, joins, or aggregate planning.tests-session-config: no candidates; no regression expected-output, session/config propagation, compatibility, or basic CI/style issue was substantiated.- Final convergence round 1 ended with both live subagents replying
NO_NEW_VALUABLE_FINDINGSfor the same ledger and empty proposed inline comment set.
User focus response: no additional user-provided review focus was present.
Validation limits: this runner is a shallow checkout and lacks thirdparty/installed, so I did not run the external p2 regression. Review was static, using the GitHub PR patch/API metadata and local surrounding code.
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)