branch-4.1: [fix](regression) match audit internal query error by injected tablet#65234
Open
shuke987 wants to merge 1 commit into
Open
branch-4.1: [fix](regression) match audit internal query error by injected tablet#65234shuke987 wants to merge 1 commit into
shuke987 wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
Contributor
|
skip buildall |
yiguolei
previously approved these changes
Jul 6, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
288fb27 to
9954d53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
test_audit_log_internal_query_failurevalidates that a failed internal statsquery is audited as
ERR. The case currently finds the audit row by requiringqueried_tables_and_viewsto contain the exact user table name.That auxiliary field is brittle for the failed internal-query path. In the
latest branch-4.1 failure, the injected tablet-scoped
IO_ERRORhappened, butthe audit lookup stayed empty because of the exact
queried_tables_and_viewsfilter.
This PR keeps the product assertion but matches the audit row by the evidence
that uniquely belongs to this run:
is_internal = 1state = 'ERR'error_messagecontainsIO_ERRORerror_messagecontains the injectedtabletIdtime >= startTimeIt also logs the recent internal audit rows if the lookup still fails, so the
next failure is easier to diagnose.
Evidence
fault_injection_p0.test_audit_log_internal_query_failure.test_audit_log_internal_query_failure.expected an audit_log entry with state=ERR for the failed gather query.IO_ERRORduringanalyze table test_audit_log_internal_query_failure_t1 with sync.so this is not only the older audit-loader batch assembly race.
Testing
git diff --checkgroovy -e 'new GroovyShell().parse(new File(args[0])); println "OK"' regression-test/suites/fault_injection_p0/test_audit_log_internal_query_failure.groovy