Skip to content

[fix](test) Set profile level for writer profile case#65232

Open
shuke987 wants to merge 1 commit into
apache:branch-4.1from
shuke987:fix-branch41-test-writer-profile
Open

[fix](test) Set profile level for writer profile case#65232
shuke987 wants to merge 1 commit into
apache:branch-4.1from
shuke987:fix-branch41-test-writer-profile

Conversation

@shuke987

@shuke987 shuke987 commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fix branch-4.1 query_profile/test_writer_profile by explicitly setting profile_level=1 before the first INSERT profile check.

The case verifies that writer details are hidden at profile level 1 and present at profile level 2. branch-4.1 now defaults profile_level to 2, so the first half must set the intended level explicitly instead of depending on the old default.

Testing

  • git diff --check
  • Runtime regression test not run locally; requires branch-4.1 regression environment with S3 credentials

@shuke987 shuke987 requested a review from yiguolei as a code owner July 6, 2026 03:31
@shuke987

shuke987 commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator Author

run buildall

@shuke987

shuke987 commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator Author

review

@shuke987

shuke987 commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator Author

/review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review opinion: no blocking issues found.

I reviewed the PR diff and the relevant profile/session propagation paths. The change is limited to regression-test/suites/query_profile/test_writer_profile.groovy, adding set profile_level=1 before the negative writer-profile assertion and restoring a trailing newline. This matches the backend behavior: writer detail profiles are emitted only when enable_profile is true and profile_level >= 2, while profile_level defaults to 2 and is forwarded through SessionVariable.toThrift().

Critical checkpoints:

  • Changed-file scope: GitHub reports only regression-test/suites/query_profile/test_writer_profile.groovy changed.
  • Existing review context: no existing inline review comments or replies were present in the prepared context, and the PR comments API returned none before submission.
  • AGENTS/code-review skill: no required AGENTS.md files were listed. I searched for a repo-local SKILL.md/code-review skill in this checkout before diff review, but none was present, so the prompt rules were used directly.
  • Correctness/session behavior: the added session setting is consistent with the intended test isolation for the first profile check; the second half explicitly sets profile_level=2 before checking detailed writer profile output.
  • Duplicate/unresolved candidates: none remained after the final sweep.
  • Validation: static review only. The local checkout is grafted/shallow (HEAD^ is unavailable), so I used GitHub PR metadata/patch as the authoritative diff source. I did not run the S3-backed regression suite in this runner.

User focus: no additional user-provided review focus was supplied.

Subagent conclusions:

  • optimizer-rewrite: no optimizer/rewrite correctness candidate; initial pass and convergence both returned NO_NEW_VALUABLE_FINDINGS.
  • tests-session-config: no test/session/config candidate; initial pass and convergence both returned NO_NEW_VALUABLE_FINDINGS.
  • Convergence round 1 ended with both live subagents returning NO_NEW_VALUABLE_FINDINGS for the same empty proposed final comment set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant