[fix](regression) stabilize branch-4.1 colocate column order test#65231
Open
shuke987 wants to merge 1 commit into
Open
[fix](regression) stabilize branch-4.1 colocate column order test#65231shuke987 wants to merge 1 commit into
shuke987 wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
Collaborator
Author
|
/review |
Contributor
There was a problem hiding this comment.
Automated review summary for PR #65231
Opinion: I did not find a blocking issue or a substantiated inline comment for this one-file regression-test stabilization.
Critical checkpoints:
- Read the review prompt, review metadata bundle, existing review context, changed-file list, required-agents file, and shared ledger before inspecting the diff.
- No required AGENTS.md files were listed for the changed-file ancestors. The repo-local
.claude/skills/code-review/SKILL.mdwas not present after hidden-path search, so the review proceeded with the bundle instructions and shared-ledger workflow. - GitHub PR metadata confirms the live head is
754c7efc261eb526d9cc0d83a9b6cbac65071131, with onlyregression-test/suites/correctness_p0/test_colocate_join_of_column_order.groovychanged. - Existing inline review context was empty, so no duplicate suppression was needed.
- The patch matches the upstream master stabilization from PR #64940 by pinning
parallel_pipeline_task_num=1for the target explain statement, and this branch additionally removes the older injected-stats workaround. - The relevant
SET_VARpath appliesparallel_pipeline_task_numas a statement-scoped session variable, andConnectContext.getTotalInstanceNum()feeds the bucket-shuffle downgrade threshold that the test is stabilizing. - After fetching the prompt base SHA,
git diff --checkpassed for the reviewed base/head range and changed file.
Validation limits:
- I did not run the Doris regression suite locally; this case depends on the Cloud P0-compatible regression environment.
- At review time, several GitHub checks were passing, while macOS BE UT, TeamCity compile, and this code-review workflow were still pending.
User focus points:
- No additional user-provided review focus was supplied.
Subagent conclusions:
optimizer-rewrite: no candidate findings; reviewed optimizer/rewrite, colocate, bucket-shuffle, and semantic-equivalence paths.tests-session-config: no candidate findings; reviewed regression-test behavior, expected-output stability, session/config propagation, compatibility, and basic CI/style signals.- Final convergence round 1 ended with both live subagents replying
NO_NEW_VALUABLE_FINDINGSfor the same final ledger and empty proposed inline comment set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Backport the final master-side stabilization for
test_colocate_join_of_column_orderto branch-4.1.Master PR #64940 fixed this case by pinning
parallel_pipeline_task_num=1in the three-table colocate explain query. Branch-4.1 still had the earlier stats-injection workaround from #64613, but later failure evidence showed stats pinning was not the root cause: the flaky plan shape is driven by bucket-shuffle downgrade under higher runtime parallelism.This patch removes the obsolete stats injection and pins
parallel_pipeline_task_num=1for the target explain SQL.Related to #64960.
Follow-up/backport of #64940.
Testing
git diff --check