[branch-4.1][fix](test) backport check_before_quit variant round-trip fix#65228
Merged
yiguolei merged 2 commits intoJul 6, 2026
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
Collaborator
Author
|
/review |
Contributor
There was a problem hiding this comment.
Automated review completed for PR #65228.
I reviewed the two changed regression scripts, the GitHub patch metadata, existing inline review context, and the relevant variant session-default/parser/type rendering paths. I did not find a substantiated issue that needs an inline review comment.
Critical checkpoints:
- Changed files: checked
check_before_quit.groovyandvariant_p0/doc_mode/predefine/load.groovy. - Duplicate context: no existing inline review comments or replies were present.
- Variant default pinning: the new doc-mode pin matches the existing round-trip check intent; the other actually randomized variant defaults in
initFuzzyModeVariables()are already pinned by the surrounding block. - Doc-mode schema-change columns: the explicit
variant_enable_doc_mode=falseproperties are accepted by the parser, do not combine with mutually exclusive variant properties, and keep the legacy flatten-nested table consistent with the existing expected-output shape. - User focus: no additional user-provided focus was supplied.
- Repo skill note: the requested repo-local code-review
SKILL.mdwas not present in this checkout after explicit search, so I proceeded with the prompt workflow and shared-ledger/subagent process. - Validation limits: static review only. The local checkout does not contain the PR base commit, so I used GitHub PR patch/file metadata as the diff authority; I did not run the regression suites.
Subagent conclusions:
optimizer-rewrite: no candidates in the initial pass; convergence round 1 returnedNO_NEW_VALUABLE_FINDINGS.tests-session-config: proposedTSC-001aboutdefault_variant_enable_nested_group; I dismissed it with evidence because that variable is not randomized bySessionVariable.initFuzzyModeVariables()andVariableMgrhas no separate reflective fuzzy randomizer. Convergence round 1 returnedNO_NEW_VALUABLE_FINDINGS.
Overall opinion: no blocking correctness or test-stability issue found in this PR.
yiguolei
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick the master fix from #65093 to
branch-4.1.default_variant_enable_doc_mode=falsebeforecheck_before_quitrecreates tables fromSHOW CREATE TABLE.test_predefine1flatten-nested table in non-doc mode, so the table left byvariant_p0/doc_mode/predefine/load.groovyremains recreate-able bySHOW CREATE TABLE.branch-4.1already had the older #64613 pinning for max subcolumns and sparse hash shard count. This backport adds the missing doc-mode pin and the follow-up flatten-nested table fix.Testing
git diff --check origin/branch-4.1...HEADcheck_before_quitvalidates the state left by a full regression pipeline.