Skip to content

[fix](regression) check partition minmax only#65180

Merged
hello-stephen merged 1 commit into
apache:masterfrom
shuke987:fix-partition-key-minmax-minmax-check
Jul 3, 2026
Merged

[fix](regression) check partition minmax only#65180
hello-stephen merged 1 commit into
apache:masterfrom
shuke987:fix-partition-key-minmax-minmax-check

Conversation

@shuke987

@shuke987 shuke987 commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Proposed changes

partition_key_minmax is intended to validate that partition-pruned memo-plan statistics tighten partition-key min/max for RANGE and LIST partitions.

The previous exact checks also depended on ndv/count, which are derived from selected partition row count and can vary with async physical row-count reporting (0, -1 unknown, or positive). Waiting for physical row count via show index stats was too strict and caused P0 timeout when strict row count stayed -1.

This patch removes the physical row-count wait and uses check {} to assert only the partition-key min/max invariants:

  • RANGE a#0 has min=5 and an accepted max of 30 or 22
  • LIST id#0 has min=max=3

Testing

  • git diff --check

Targeted regression was not run locally; CI will cover it.

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@shuke987

shuke987 commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator Author

run buildall

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions Bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 3, 2026
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@hello-stephen hello-stephen merged commit 3f0200c into apache:master Jul 3, 2026
33 checks passed
yiguolei pushed a commit that referenced this pull request Jul 7, 2026
## Proposed changes

Backport #65180 to branch-4.1. On branch-4.1, `partition_key_minmax`
still lives under `nereids_p0/stats`, so this applies the same final fix
to the branch-specific path instead of directly picking the master file
path.

The case is intended to validate partition-pruned partition-key min/max.
The previous checks also depended on `ndv/count`, which can vary with
async physical row-count reporting. This patch keeps the existing
RANGE/LIST queries and checks only the partition-key min/max invariants.

## Testing

- `git diff --check --
regression-test/suites/nereids_p0/stats/partition_key_minmax.groovy`
- `git diff --check HEAD^ HEAD --
regression-test/suites/nereids_p0/stats/partition_key_minmax.groovy`

Targeted regression was not run locally; CI will cover it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.1.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants