[fix](maxcompute)Fix MaxCompute IN predicate pushdown polarity.#65083
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
FE UT Coverage ReportIncrement line coverage |
TPC-H: Total hot run time: 29429 ms |
TPC-DS: Total hot run time: 174228 ms |
ClickBench: Total hot run time: 25.26 s |
|
/review |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Review summary:
I found one blocking issue: the changed MaxCompute IN/NOT IN polarity branch is not covered by local FE tests, and the current PR head still has check_coverage_fe (Coverage) failing. The end-to-end MaxCompute regression is useful, but it is remote-gated and does not satisfy the FE coverage job.
Critical checkpoints:
- Goal: fixes MaxCompute IN predicate pushdown polarity; code maps non-negated IN to ODPS IN and NOT IN to ODPS NOT_IN.
- Scope: small and focused, limited to the converter plus a regression suite/output.
- Parallel paths: the newer connector MaxCompute predicate converter already uses matching polarity; no additional parallel-path issue found.
- Concurrency/lifecycle/persistence/config/protocol: not materially changed.
- Tests: remote regression added and expected output is ordered; local FE coverage for the changed Java branch is missing, matching the failing coverage check.
- Validation: static review plus GitHub PR metadata/checks; local FE build/tests were not run because this runner lacks
thirdparty/installed/bin/protoc.
Subagent conclusions: optimizer-rewrite found no new valuable findings; tests-session-config raised TSC-1, which was accepted as MAIN-1 and submitted as the inline comment. Final convergence round 1 ended with both subagents replying NO_NEW_VALUABLE_FINDINGS for the same ledger/comment set.
User focus: no additional user-provided review focus was supplied.
fix maxcompute error in predicate pushdown.
What problem does this PR solve?
Problem Summary:
fix maxcompute error in predicate pushdown.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)