[refine](util) add cast_to_column to cast ColumnPtr #58092
Merged
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34114 ms |
TPC-DS: Total hot run time: 188488 ms |
ClickBench: Total hot run time: 27.6 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Mryange
force-pushed
the
util-cast-to-column
branch
from
d1f9ba3 to
797bc20
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 36086 ms |
TPC-DS: Total hot run time: 179320 ms |
ClickBench: Total hot run time: 27.53 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Mryange
force-pushed
the
util-cast-to-column
branch
from
797bc20 to
0aa4d21
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 36552 ms |
TPC-DS: Total hot run time: 178620 ms |
ClickBench: Total hot run time: 27.51 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
TPC-DS: Total hot run time: 180711 ms |
ClickBench: Total hot run time: 27.1 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
zclllyybb
approved these changes
Dec 18, 2025
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Gabriel39
approved these changes
Dec 18, 2025
16 tasks
yiguolei
pushed a commit
that referenced
this pull request
Jun 30, 2026
### What problem does this PR solve? Related PR: #63491, #63678, #63946, #58092 Problem Summary: Backport the column strong-typing refinements for branch-4.1: use strong typed nullable null maps, array offsets, and map offsets, and apply the column check helper for type casts. Branch-4.1 was missing the COW/Column cast helper introduced by #58092, so this also ports the minimal helper API needed by the picked changes and adjusts an old array distance code path to use the already strong typed offsets pointer. ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This is similar to std::dynamic_pointer_cast.
ColumnPtr column_ptr = ColumnHelper::create_column<DataTypeInt32>({1, 2, 3}); EXPECT_EQ(column_ptr->use_count(), 1); ColumnInt32::Ptr column_i32 = cast_to_column<ColumnInt32>(column_ptr); EXPECT_TRUE(column_i32); EXPECT_EQ(column_ptr->use_count(), 2); EXPECT_EQ(column_i32->use_count(), 2); MutableColumnPtr column_ptr = ColumnInt32::create(); EXPECT_EQ(column_ptr->use_count(), 1); ColumnInt32::MutablePtr column_i32 = cast_to_column<ColumnInt32>(std::move(column_ptr)); EXPECT_TRUE(column_i32); EXPECT_EQ(column_i32->use_count(), 1);Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)