[opt](nereids)use SetPreAggStatus rule instead of AdjustPreAggStatus with join limited#48502
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31861 ms |
Closed
16 tasks
TPC-DS: Total hot run time: 190880 ms |
ClickBench: Total hot run time: 31.27 s |
b5d48bb to
9957558
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 30473 ms |
TPC-DS: Total hot run time: 45834 ms |
ClickBench: Total hot run time: 30.92 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 30510 ms |
TPC-DS: Total hot run time: 56958 ms |
ClickBench: Total hot run time: 30.34 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31653 ms |
TPC-DS: Total hot run time: 184860 ms |
ClickBench: Total hot run time: 31.38 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31476 ms |
TPC-DS: Total hot run time: 190613 ms |
ClickBench: Total hot run time: 30.3 s |
641dfda to
137c8b7
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32930 ms |
TPC-DS: Total hot run time: 185347 ms |
ClickBench: Total hot run time: 31.09 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34001 ms |
TPC-DS: Total hot run time: 186346 ms |
ClickBench: Total hot run time: 29.12 s |
Contributor
|
good refactor, more clear |
morrySnow
approved these changes
May 13, 2025
924060929
approved these changes
May 13, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…with join limited (apache#48502) The old AdjustPreAggStatus rule can't set preagg open if there is a join node under agg node. But in some senario, the preagg can be set to open as bellow: ``` agg (sum(t1.a),max(t2.a)) |- join |- t1 PREAGG ON (The data produced by join has no impact on max(t2.a)) |- t2 PREAGG OFF(The data produced by join will make sum(t1.a) incorrect, so the preagg is set to off) ``` The new SetPreAggStatus rule is enhanced to handle such case
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old AdjustPreAggStatus rule can't set preagg open if there is a join node under agg node. But in some senario, the preagg can be set to open as bellow:
The new SetPreAggStatus rule is enhanced to handle such case
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)