chore: downsize sql_planner_extended logical_plan_optimize sample size to 5#23659
Merged
2010YOUY01 merged 2 commits intoJul 18, 2026
Merged
Conversation
2010YOUY01
approved these changes
Jul 17, 2026
2010YOUY01
left a comment
Contributor
There was a problem hiding this comment.
Makes sense to me, thank you.
This micro bench takes 30s to run, 10 samples still takes a lot of time. Perhaps we can do 5? The result should not be very noisy since it's a very long-running bench case.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23659 +/- ##
=======================================
Coverage 80.66% 80.67%
=======================================
Files 1086 1086
Lines 366694 366691 -3
Branches 366694 366691 -3
=======================================
+ Hits 295806 295817 +11
+ Misses 53265 53244 -21
- Partials 17623 17630 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
i agree, downsized to 5 👍 |
sql_planner_extended logical_plan_optimize sample size to 10sql_planner_extended logical_plan_optimize sample size to 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on my M4 Macbook pro, it estimates it would take 50 minutes (!) to run the benchmark
datafusion (main)$ cargo bench -p datafusion --bench sql_planner_extended logical_plan Compiling datafusion-common v54.0.0 (/Users/jeffrey/Code/datafusion/datafusion/common) ... Compiling datafusion v54.0.0 (/Users/jeffrey/Code/datafusion/datafusion/core) Finished `bench` profile [optimized] target(s) in 8m 11s Running benches/sql_planner_extended.rs (/Users/jeffrey/.cargo_target_cache/release/deps/sql_planner_extended-c026520b80bba716) Gnuplot not found, using plotters backend Benchmarking logical_plan_optimize: Warming up for 3.0000 s Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 3077.4s, or reduce sample count to 10. Benchmarking logical_plan_optimize: Collecting 100 samples in estimated 3077.4 s (100 iterations)and running it via the bot just times out: #23215 (comment)
so might actually be useful to reduce the sample size so it can actually run and be of use to us