fix: Correct join cardinality estimation for semi and anti joins with disjoint column ranges#22674
Merged
Dandandan merged 1 commit intoJun 1, 2026
Conversation
Contributor
|
Nice correctness fix 🚀 |
nathanb9
approved these changes
May 31, 2026
Dandandan
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
estimate_join_cardinalityfor semi-joins is buggy for non-join-key disjoint columns #22673Rationale for this change
estimate_join_cardinalityfor semi-joins checks if ANY of the columns in the two join inputs are disjoint (comparing columns positionally); if so, it claims the join will not return any rows. This is wrong, for two reasons:A similar issue exists for anti-joins, except we assume the anti-join will return the entire join input in this case.
We should instead just check for disjoint ranges between the pairs of columns that make up the join key.
What changes are included in this PR?
estimate_join_cardinalitybehavior in the face of disjoint column ranges that aren't join key columnsestimate_join_cardinality, rename a variable for clarityAre these changes tested?
Yes, new test added.
Are there any user-facing changes?
Better plans / avoid buggy cardinality estimate.