Add Round trip tests for Array <--> ScalarValue#13777
Merged
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
When trying to write a unit test for #13762 I found there was no good place to test the round tripping of Array --> ScalarValue --> Array (which is what is done for constant values)
So I wrote some
What changes are included in this PR?
Add tests for this path, with ones that fail due to bugs commented out
Are these changes tested?
Yes, by CI
Are there any user-facing changes?
No - this are just tests