perf: optimize spark_arrays_overlap (up to 18x faster)#4906
Merged
andygrove merged 2 commits intoJul 15, 2026
Merged
Conversation
spark_arrays_overlap (up to 18x faster)
andygrove
marked this pull request as ready for review
July 13, 2026 15:43
comphead
approved these changes
Jul 15, 2026
comphead
left a comment
Contributor
There was a problem hiding this comment.
Thnaks @andygrove we need to donate those optimizations to datafusion-spark one day
…et-20260713-090146
andygrove
deleted the
auto-opt/spark_arrays_overlap-datafusion-comet-20260713-090146
branch
July 15, 2026 16:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Optimize existing expression.
What changes are included in this PR?
Replaced the per-probe-element Arrow eq kernel call (which allocated a BooleanArray per element) with typed scans over the flat values buffers plus a hash probe for large lists, cutting allocations and kernel dispatches to zero on flat element types.
How are these changes tested?
Existing tests.
Benchmark (criterion):
Full criterion output: