Fix backup type parameter version number in ListBackupsCmd - #14078
Fix backup type parameter version number in ListBackupsCmd#14078DaanHoogland wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The diff sets since = "24.0" (and not a 4.x.y version), which conflicts with the PR’s stated intent and the established version format used across the API commands.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the API parameter metadata for ListBackupsCmd by changing the since version string on the type (ApiConstants.TYPE) parameter, which influences CloudStack API documentation/version tracking for that parameter.
Changes:
- Adjusted the
sincevalue for thetypeparameter inListBackupsCmd.
File summaries
| File | Description |
|---|---|
| api/src/main/java/org/apache/cloudstack/api/command/user/backup/ListBackupsCmd.java | Changes the since version metadata for the type parameter of the list-backups API command. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14078 +/- ##
============================================
+ Coverage 3.53% 19.78% +16.25%
- Complexity 0 19994 +19994
============================================
Files 487 6371 +5884
Lines 41865 575907 +534042
Branches 7913 70496 +62583
============================================
+ Hits 1479 113951 +112472
- Misses 40171 449529 +409358
- Partials 215 12427 +12212
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 24.68% |
| Branch coverage | 18.89% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
45d6840 to
2616a3e
Compare
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
|
Description
This PR fixes a too quickly committed 24.0 version number in a PR created before the version change got voted in ...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?