You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)
Feature/Enhancement Scale or Bug Severity
Bug Severity
BLOCKER
Critical
Major
Minor
Trivial
Screenshots (if appropriate):
How Has This Been Tested?
Network Offering clone:
Clone an existing isolated network offering, change say, userdata provider from VirtualRouter to ConfigDrive and submit. listNetworkOfferings on the result and confirm the new provider actually persisted.
Clone the same offering, leave services untouched, submit - confirm it clones same as source
Clone an NSX-backed offering - confirm services/providers stay greyed out and fixed, unaffected by any of the above.
VPC Offering clone:
Clone a VPC offering, edit Name/Display Text/Service Offering/Redundant Router, then change Network Mode (NATTED <->ROUTED) before submitting - confirm those edits survive
While in NATTED, check/uncheck a couple of services and change their providers, then flip to ROUTED and back to NATTED - confirm the edits to available services are preserved, and confirm mode-excluded services (SourceNat/StaticNat/Lb/PortForwarding/Vpn) are unchecked in ROUTED and require an explicit re-check after returning to NATTED
Submit after a mode change (as in test 2) and confirm the API payload doesn't include stale entries for services no longer shown in the form .
How did you try to break this feature and the system with this change?
@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
The conserve mode check is missing when a user tries to clone a vpc service offering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes: #14056
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Network Offering clone:
VPC Offering clone:
How did you try to break this feature and the system with this change?