Skip to content

OSS-Fuzz: Improve fuzz_thrift - #3676

Open
arthurscchan wants to merge 2 commits into
apache:masterfrom
arthurscchan:brpc-thrift-ship
Open

arthurscchan wants to merge 2 commits into
apache:masterfrom
arthurscchan:brpc-thrift-ship

Conversation

@arthurscchan

Copy link
Copy Markdown
Contributor

This PR add corpus seeds for fuzz_thrift, together with google/oss-fuzz#16364 to install missing modules for fuzz_thrift, aiming to improve the fuzzing coverage and effectiveness of project brpc.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new integration breaks fuzz builds with Thrift disabled and enables a harness that leaks memory on successful parses.

3 open issues
What changed in this PR

This PR integrates the Thrift fuzzer into bRPC’s OSS-Fuzz build and packages its seed corpus, complementing the dependency installation changes in google/oss-fuzz#16364.

Changes:

  • Register fuzz_thrift as a CMake fuzz target.
  • Enable Thrift in OSS-Fuzz and package its libraries and corpus.
  • Add a short-input corpus seed.
File Description
test/​fuzzing/​oss-fuzz.sh Enables and builds the Thrift fuzzer and packages runtime libraries and seeds.
test/​fuzzing/​fuzz_thrift_seed_corpus/​short.bin Adds a seed intended to exercise short-input handling.
test/​CMakeLists.txt Adds fuzz_thrift to the fuzz-target list.

Review effort: Balanced

Comment thread test/CMakeLists.txt Resolved
Comment thread test/fuzzing/oss-fuzz.sh Resolved
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
Signed-off-by: Arthur SC Chan <arthur.chan@adalogics.com>
@wwbmmm

wwbmmm commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Please don't add binary files to the apache brpc source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants